From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: 62894@debbugs.gnu.org
Subject: [bug#62894] [PATCH core-updates 0/2] gnu: samba: Fix build on i686-linux.
Date: Mon, 17 Apr 2023 04:23:49 +0000 [thread overview]
Message-ID: <87jzybrval.fsf@protonmail.com> (raw)
Hi Guix,
Two patches here:
1. Fix samba building on i686-linux, as the selftest configure option requires python-cryptography, which relies on rust and thus won't work on i686 currently. So conditionally enable this flag and that native-input.
The check here happens twice, better to have a let form for the whole package (or even reduce it to a "rust?" variable)? I went with the check we use for librsvg, but haven't checked on aarch64 if this does build. I did test that samba builds for x86_64 and i686-linux and this allows wine on x86_64 to build for me as well.
2. In doing this I noticed that samba is outdated and vulnerable to CVEs so I updated it in the next patch. I separately verified the download's signature, though samba's key is expired, so...
I didn't push this directly since I wasn't sure if there was a more elegant way to do this check and since I'm not certain on the rust architectures question.
A similar fix is needed on master I believe, but since the inheritance is flipped there I wasn't sure if this will just confuse the upcoming merge more. If the core-updates merge is happening soon we can wait? Or once this is good for core-updates I'll push the same fix to master.
Thanks!
John
next reply other threads:[~2023-04-17 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 4:23 John Kehayias via Guix-patches via [this message]
2023-04-17 4:33 ` [bug#62894] [PATCH core-updates 1/2] gnu: samba: Fix build on i686-linux John Kehayias via Guix-patches via
2023-04-17 4:34 ` [bug#62894] [PATCH core-updates 2/2] gnu: samba: Update to 4.18.1 John Kehayias via Guix-patches via
2023-04-18 16:35 ` [bug#62894] [PATCH core-updates 0/2] gnu: samba: Fix build on i686-linux Maxim Cournoyer
2023-05-12 20:09 ` bug#62894: " John Kehayias via Guix-patches via
2023-04-19 16:14 ` [bug#62894] " Kaelyn via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzybrval.fsf@protonmail.com \
--to=guix-patches@gnu.org \
--cc=62894@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).