From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4GewKjbKPGQrVQEASxT56A (envelope-from ) for ; Mon, 17 Apr 2023 06:25:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ACKfKjbKPGTBBwEA9RJhRA (envelope-from ) for ; Mon, 17 Apr 2023 06:25:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EDEF1E0CC for ; Mon, 17 Apr 2023 06:25:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poGQN-0001PV-6Y; Mon, 17 Apr 2023 00:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poGQK-0001PD-Tg for guix-patches@gnu.org; Mon, 17 Apr 2023 00:25:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poGQK-0006q7-AT for guix-patches@gnu.org; Mon, 17 Apr 2023 00:25:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1poGQJ-0007pJ-0J for guix-patches@gnu.org; Mon, 17 Apr 2023 00:25:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62894] [PATCH core-updates 0/2] gnu: samba: Fix build on i686-linux. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Apr 2023 04:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62894 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62894@debbugs.gnu.org X-Debbugs-Original-To: Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.168170545930025 (code B ref -1); Mon, 17 Apr 2023 04:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Apr 2023 04:24:19 +0000 Received: from localhost ([127.0.0.1]:52862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poGPa-0007oD-Qo for submit@debbugs.gnu.org; Mon, 17 Apr 2023 00:24:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:39128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poGPU-0007o0-Hs for submit@debbugs.gnu.org; Mon, 17 Apr 2023 00:24:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poGPT-0001NK-P8 for guix-patches@gnu.org; Mon, 17 Apr 2023 00:24:11 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poGPJ-0006Wn-Ft for guix-patches@gnu.org; Mon, 17 Apr 2023 00:24:11 -0400 Date: Mon, 17 Apr 2023 04:23:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1681705437; x=1681964637; bh=7cGCm2mlzHc59FKVd7eFG8B6nw0LE6e58XkYlBgFoSA=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=cK4U6+DIPjYHmPytw4ms4F9VAZG7Ap2nt5Iq/uCwoxI24Qmd7wUOGHaKN3P5wepj+ u4Ew/3JGO0c8YkT6ZT2VJyGbrdu3MthZD4zmCO/LuRBCmLcTChmMKp24gAll88/Zgi v5AVnDrsO47UkIjDWd/9WZQtnaTr1ALqbS3pSbfcmrFGeyYjIt6yO2wm/xUI79gGBx Uzgm+cpf5zvV6ImkGcgtjzsRwMaBqDJpyjDfwuQNWxVaGo0nbeBzSzvdGThu/deE7U vhzcGJp9xGc3TURC51hg9MI5835GuaeAca64xQ1mhsGbX67Id9/4aSxfABclc+rnTA OzS6Qd+TB6Seg== Message-ID: <87jzybrval.fsf@protonmail.com> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.22; envelope-from=john.kehayias@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681705526; a=rsa-sha256; cv=none; b=kFM+wHQWzrNJB0961Qvog3CTdAh8gKuN7Wm58h37j4h5EHoMjxzcQLWqCTI1ibtQMjEM+p V8eeHvxrW22IVx/ie1CUZRdSYqsE9U4tQni3NzeG1R+30eUNlcmTMSUiHW+a20bWtPOxRM bPML40vKg9G87CDWlWK0Xg1zokvL7AmRsiV/oGj7LBYp6Rb7zHHND6dslp8hDW70dzGDuy pFQ0LXAXdyv75FiJ7Cnbku0UDFuKDa6OFLLc2qqbvhPBohGmWeSEWdc/TOr89gvcqIFl6A ILaLhpIJlKMq4JY8sZrk3kYEi5SZ8acFFbhc+jbF1apc034SpLuS9QUcLsSKAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=cK4U6+DI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681705526; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=7cGCm2mlzHc59FKVd7eFG8B6nw0LE6e58XkYlBgFoSA=; b=ZN+9REGvY2oXsaMI72dIaPJeiW2YuBWP3Om7t8oL0QOny3vLHJTnl1r5kBPfYQbK5Bhg8c qTl/EepfVywuC1BvTrIoF5dbhKMI2hzRv5HB93x8J/jpcKbLxPt0AfoUtGMNjEZq8JgfXQ VUIdefJCAX7hiKN7X2msw9gQskdMgf0NhqKRqoKyzfvZ+tvHOU1ljB2o56pYP126EAswxd fFbOUbSSIg6bgJZAOuHDNw6N+TVQ+g7kB+AvQwrFCPX1Mv5tfvYej1wwWOL0fPG+nvugYH a7c9T4EGx2e+eGxDngsOY/a5AXv1lVZXRRq/paw/XdH2+AqCvsmgRc1pgv1u6A== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.41 X-Spam-Score: -2.41 X-Migadu-Queue-Id: 2EDEF1E0CC Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=cK4U6+DI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: 6kyg/YlUjtSg Hi Guix, Two patches here: 1. Fix samba building on i686-linux, as the selftest configure option requi= res python-cryptography, which relies on rust and thus won't work on i686 c= urrently. So conditionally enable this flag and that native-input. The check here happens twice, better to have a let form for the whole pa= ckage (or even reduce it to a "rust?" variable)? I went with the check we u= se for librsvg, but haven't checked on aarch64 if this does build. I did te= st that samba builds for x86_64 and i686-linux and this allows wine on x86_= 64 to build for me as well. 2. In doing this I noticed that samba is outdated and vulnerable to CVEs so= I updated it in the next patch. I separately verified the download's signa= ture, though samba's key is expired, so... I didn't push this directly since I wasn't sure if there was a more elegant= way to do this check and since I'm not certain on the rust architectures q= uestion. A similar fix is needed on master I believe, but since the inheritance is f= lipped there I wasn't sure if this will just confuse the upcoming merge mor= e. If the core-updates merge is happening soon we can wait? Or once this is= good for core-updates I'll push the same fix to master. Thanks! John