From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: Zheng Junjie <zhengjunjie@iscas.ac.cn>,
66424@debbugs.gnu.org, Marius Bakke <marius@gnu.org>
Subject: [bug#66424] [PATCH core-updates] gnu: libxkbcommon: Fix cross-compile.
Date: Fri, 13 Oct 2023 10:49:01 -0400 [thread overview]
Message-ID: <87jzrq60iq.fsf@gmail.com> (raw)
In-Reply-To: <87r0lz7lzg.fsf@protonmail.com> (John Kehayias's message of "Thu, 12 Oct 2023 18:07:56 +0000")
Hi John,
John Kehayias <john.kehayias@protonmail.com> writes:
> Hello,
>
> (CC'ing authors of two related commits too)
>
> On Mon, Oct 09, 2023 at 11:07 PM, Zheng Junjie wrote:
>
>> * gnu/packages/xdisorg.scm (libxkbcommon): Fix cross-compile.
>> [native-inputs]: When cross-compile add PKG-CONFIG-FOR-BUILD.
>> ---
>> gnu/packages/xdisorg.scm | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
>> index db948a9318..84bdcad031 100644
>> --- a/gnu/packages/xdisorg.scm
>> +++ b/gnu/packages/xdisorg.scm
>> @@ -527,9 +527,13 @@ (define-public libxkbcommon
>> wayland-protocols
>> xkeyboard-config))
>> (native-inputs
>> - (list bison doxygen pkg-config python
>> - ;; wayland-scanner is required at build time.
>> - wayland))
>> + (append
>> + (if (%current-target-system)
>> + (list pkg-config-for-build)
>> + '())
>> + (list bison doxygen pkg-config python
>> + ;; wayland-scanner is required at build time.
>> + wayland)))
>> (arguments
>> (list #:configure-flags
>> #~(list (string-append "-Dxkb-config-root="
>>
>> base-commit: 9b77bd0b9b4f3de69390da0ba7db5b9dbc01e554
>
> When searching the log it looked like this had already been done on
> core-updates in 5841ac3981a3a08968704728cef14accd14e7a1c (Marius) but I
> was confused when I didn't see it. Looks like the pkg-config-for-build
> was dropped (accidentally?) in 5841ac3981a3a08968704728cef14accd14e7a1c
> (Maxim)
>
> Is this still needed?
On the top of my head, I thought pkg-config-for-build had been obsolete
by the pkg-config symbol being dynamically bound to something that makes
sense for the context it's used in, via some macro trickery. I may have
misunderstood things.
> And if so, I can do it on mesa-updates very soon, since libx11 and
> libxpm will be ungrafted and related packages (like mesa) updated too.
> Or we can leave it to core-updates if that makes more sense.
I guess it depends which branch is expected to be the shortest lived
one; I'm giving about a month to let more time for core-updates to merge
interesting bits and build the branch and fix breakage. Take this with a
grain of salt; it's not fixed in stone.
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-13 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 15:07 [bug#66424] [PATCH] gnu: libxkbcommon: Fix cross-compile Zheng Junjie
2023-10-12 18:07 ` [bug#66424] [PATCH core-updates] " John Kehayias via Guix-patches via
2023-10-13 14:49 ` Maxim Cournoyer [this message]
2023-10-14 17:30 ` zhengjunjie
2023-10-14 21:02 ` John Kehayias via Guix-patches via
2023-10-16 2:28 ` bug#66424: " John Kehayias via Guix-patches via
2023-10-16 4:42 ` [bug#66424] " Efraim Flashner
2023-10-16 13:48 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzrq60iq.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66424@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
--cc=marius@gnu.org \
--cc=zhengjunjie@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).