unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: zhengjunjie@iscas.ac.cn
Cc: Marius Bakke <marius@gnu.org>,
	Efraim Flashner <efraim@flashner.co.il>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	66424-done@debbugs.gnu.org
Subject: bug#66424: [PATCH core-updates] gnu: libxkbcommon: Fix cross-compile.
Date: Mon, 16 Oct 2023 02:28:13 +0000	[thread overview]
Message-ID: <874jirb8sv.fsf@protonmail.com> (raw)
In-Reply-To: <EA947A5D-B228-4922-BA0B-44493A1F6F18@iscas.ac.cn>

Hi all,

cc'ing Efraim too, since...

On Sun, Oct 15, 2023 at 01:30 AM, zhengjunjie@iscas.ac.cn wrote:

>> 在 2023年10月13日,22:50,Maxim Cournoyer <maxim.cournoyer@gmail.com> 写道:
>>
>>
>> On the top of my head, I thought pkg-config-for-build had been obsolete
>> by the pkg-config symbol being dynamically bound to something that makes
>> sense for the context it's used in, via some macro trickery.  I may have
>> misunderstood things
>
> For cross build,
>
> pkg-config -> xxxx-pkg-config
> pkg-config-for-build -> pkg-config
>
> libxkbcommon require wayland-scanner to generate c file, this is why
> need pkg-config-for-build, pkg-config is require by find library. Is
> different ,so libxkbcommon need both on cross build.

looks like the same change was made on master in
bc1634a197dc9ab7aa0dead8c7449bb5db09cea6. Along with other commits
then to do the same thing to other similar packages.

So, I'm closing as I believe this is done but figured I'd loop in
Efraim in case there was anything else on this matter to discuss.

Thanks all!
John





  parent reply	other threads:[~2023-10-16  2:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 15:07 [bug#66424] [PATCH] gnu: libxkbcommon: Fix cross-compile Zheng Junjie
2023-10-12 18:07 ` [bug#66424] [PATCH core-updates] " John Kehayias via Guix-patches via
2023-10-13 14:49   ` Maxim Cournoyer
2023-10-14 17:30     ` zhengjunjie
2023-10-14 21:02       ` John Kehayias via Guix-patches via
2023-10-16  2:28       ` John Kehayias via Guix-patches via [this message]
2023-10-16  4:42         ` Efraim Flashner
2023-10-16 13:48           ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jirb8sv.fsf@protonmail.com \
    --to=guix-patches@gnu.org \
    --cc=66424-done@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=john.kehayias@protonmail.com \
    --cc=marius@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).