From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26815@debbugs.gnu.org
Subject: bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.
Date: Mon, 08 May 2017 16:45:27 +0200 [thread overview]
Message-ID: <87inlbl854.fsf@gnu.org> (raw)
In-Reply-To: <20170507220751.4d45ece0@scratchpost.org> (Danny Milosavljevic's message of "Sun, 7 May 2017 22:07:51 +0200")
Danny Milosavljevic <dannym@scratchpost.org> skribis:
>>+(define* (format-partition partition type
>>+ #:key label)
>>+ "Create a file system TYPE on PARTITION. If LABEL is true, use that as the
>>+volume name."
>>+ (cond
>>+ ((string-prefix? "ext" type)
>>+ (create-ext-file-system partition type #:label label))
>>+ ((string-suffix? "fat" type)
>>+ (create-fat-file-system partition #:label label))
>>+ (else (error "Unsupported file system."))))
>
> ^^^ Indentation of the "else" is strange.
>
> Otherwise LGTM!
Same here!
Ludo'.
next prev parent reply other threads:[~2017-05-08 14:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 14:35 bug#26815: [PATCH 0/3] Hybrid UEFI disk image Marius Bakke
2017-05-07 14:36 ` bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags Marius Bakke
2017-05-07 14:36 ` bug#26815: [PATCH 2/3] vm: Support creating FAT partitions Marius Bakke
2017-05-07 15:26 ` Danny Milosavljevic
2017-05-07 15:52 ` Marius Bakke
2017-05-07 16:32 ` bug#26815: [PATCH v2 " Marius Bakke
2017-05-07 17:06 ` bug#26815: [PATCH " Danny Milosavljevic
2017-05-07 19:15 ` Marius Bakke
2017-05-07 20:07 ` Danny Milosavljevic
2017-05-08 14:45 ` Ludovic Courtès [this message]
2017-05-08 15:59 ` Maxim Cournoyer
2017-05-07 14:36 ` bug#26815: [PATCH 3/3] vm: Support EFI boot in base image Marius Bakke
2017-05-07 15:18 ` Danny Milosavljevic
2017-05-07 15:41 ` Marius Bakke
2017-05-07 19:17 ` Marius Bakke
2017-05-08 9:06 ` Marius Bakke
2017-05-08 14:50 ` Ludovic Courtès
2017-05-10 19:52 ` bug#26815: [PATCH 1/3] vm: Support arbitrary partition flags Marius Bakke
2017-05-10 19:52 ` bug#26815: [PATCH 2/3] vm: Support creating FAT partitions Marius Bakke
2017-05-10 19:52 ` bug#26815: [PATCH 3/3] vm: Add UEFI loader to disk images Marius Bakke
2017-05-10 21:05 ` Ludovic Courtès
2017-05-10 21:21 ` Marius Bakke
2017-05-10 19:58 ` bug#26815: [PATCH 3/3] vm: Support EFI boot in base image Marius Bakke
2017-05-12 22:06 ` Ludovic Courtès
2017-05-12 23:12 ` Marius Bakke
2017-05-13 9:17 ` Mathieu Othacehe
2017-05-13 13:11 ` Ludovic Courtès
2017-05-13 14:13 ` Marius Bakke
2017-05-13 19:23 ` Ludovic Courtès
2017-05-16 15:17 ` Ludovic Courtès
2017-05-17 11:05 ` Marius Bakke
2017-05-17 12:36 ` Marius Bakke
2017-05-17 13:42 ` Ricardo Wurmus
2017-05-17 19:47 ` Ludovic Courtès
2017-05-17 11:05 ` bug#26815: [PATCH v4 1/3] vm: Support arbitrary partition flags Marius Bakke
2017-05-17 11:05 ` bug#26815: [PATCH v4 2/3] vm: Support creating FAT partitions Marius Bakke
2017-05-17 11:05 ` bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images Marius Bakke
2017-05-17 21:28 ` Ludovic Courtès
2017-05-18 16:21 ` Marius Bakke
2017-05-18 17:34 ` Marius Bakke
2017-05-18 20:59 ` Ludovic Courtès
2017-05-19 16:15 ` Marius Bakke
2017-05-19 17:37 ` Mathieu Othacehe
2017-05-19 18:06 ` Marius Bakke
2017-05-20 8:25 ` Ludovic Courtès
2017-05-20 8:55 ` Mathieu Othacehe
2017-05-20 9:23 ` Marius Bakke
2017-05-20 9:36 ` Ludovic Courtès
2017-05-20 9:36 ` Mathieu Othacehe
2017-05-20 10:05 ` Marius Bakke
2017-05-19 21:21 ` Ludovic Courtès
2017-05-18 20:50 ` Ludovic Courtès
2017-05-18 22:52 ` Marius Bakke
2017-05-19 7:00 ` Ludovic Courtès
2017-05-17 21:21 ` bug#26815: [PATCH v4 1/3] vm: Support arbitrary partition flags Ludovic Courtès
2017-05-07 15:28 ` bug#26815: [PATCH 1/3] vm: Add support for " Danny Milosavljevic
2017-05-08 14:43 ` Ludovic Courtès
2017-05-08 15:55 ` Maxim Cournoyer
2017-05-08 21:41 ` Danny Milosavljevic
2017-05-07 15:02 ` bug#26815: [PATCH 0/3] Hybrid UEFI disk image Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inlbl854.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26815@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).