From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7jvK-0007us-5I
	for guix-patches@gnu.org; Mon, 08 May 2017 10:46:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7jvG-0007kQ-O2
	for guix-patches@gnu.org; Mon, 08 May 2017 10:46:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36315)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7jvG-0007kK-Dv
	for guix-patches@gnu.org; Mon, 08 May 2017 10:46:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7jvG-0007VT-8K
	for guix-patches@gnu.org; Mon, 08 May 2017 10:46:02 -0400
Subject: bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.
Resent-Message-ID: <handler.26815.B26815.149425474027647@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170507143647.21036-1-mbakke@fastmail.com>
	<20170507143647.21036-2-mbakke@fastmail.com>
	<20170507172656.55edb3e9@scratchpost.org>
	<871ss0zmt0.fsf@fastmail.com>
	<20170507190637.0bf9c4ce@scratchpost.org>
	<87tw4wxyun.fsf@fastmail.com>
	<20170507220751.4d45ece0@scratchpost.org>
Date: Mon, 08 May 2017 16:45:27 +0200
In-Reply-To: <20170507220751.4d45ece0@scratchpost.org> (Danny Milosavljevic's
	message of "Sun, 7 May 2017 22:07:51 +0200")
Message-ID: <87inlbl854.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26815@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

>>+(define* (format-partition partition type
>>+                           #:key label)
>>+  "Create a file system TYPE on PARTITION.  If LABEL is true, use that as the
>>+volume name."
>>+  (cond
>>+   ((string-prefix? "ext" type)
>>+    (create-ext-file-system partition type #:label label))
>>+   ((string-suffix? "fat" type)
>>+    (create-fat-file-system partition #:label label))
>>+     (else (error "Unsupported file system."))))
>
>        ^^^ Indentation of the "else" is strange.
>
> Otherwise LGTM!

Same here!

Ludo'.