unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#28315] [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE.
@ 2017-09-01 14:14 宋文武
  2017-09-04 14:25 ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: 宋文武 @ 2017-09-01 14:14 UTC (permalink / raw)
  To: 28315

* gnu/packages/java.scm (icedtea-8)[arguments]: Copy 'nss.cfg' from JDK into
JRE in the install phase.
---
 gnu/packages/java.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 947598c7b..fe67bb3f0 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1628,6 +1628,9 @@ IcedTea build harness.")
                    (copy-recursively "openjdk.build/docs" doc)
                    (copy-recursively "openjdk.build/images/j2re-image" jre)
                    (copy-recursively "openjdk.build/images/j2sdk-image" jdk)
+                   ;; Install the nss.cfg file to JRE.
+                   (copy-file (string-append jdk "/jre/lib/security/nss.cfg")
+                              (string-append jre "/lib/security/nss.cfg"))
                    #t)))))))
       (native-inputs
        `(("jdk" ,icedtea-7 "jdk")
-- 
2.13.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#28315] [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE.
  2017-09-01 14:14 [bug#28315] [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE 宋文武
@ 2017-09-04 14:25 ` Ludovic Courtès
  2017-09-09  3:48   ` 宋文武
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-09-04 14:25 UTC (permalink / raw)
  To: 宋文武; +Cc: 28315

Hello!

宋文武 <iyzsong@member.fsf.org> skribis:

> * gnu/packages/java.scm (icedtea-8)[arguments]: Copy 'nss.cfg' from JDK into
> JRE in the install phase.

What effect does this have?

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#28315] [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE.
  2017-09-04 14:25 ` Ludovic Courtès
@ 2017-09-09  3:48   ` 宋文武
  2017-09-10 12:54     ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: 宋文武 @ 2017-09-09  3:48 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 28315

ludo@gnu.org (Ludovic Courtès) writes:

> Hello!
>
> 宋文武 <iyzsong@member.fsf.org> skribis:
>
>> * gnu/packages/java.scm (icedtea-8)[arguments]: Copy 'nss.cfg' from JDK into
>> JRE in the install phase.
>
> What effect does this have?

Before this, accessing HTTPS using the 'java' from icedtea-8 will throw
an exception about nss.cfg not available, while the 'java' from
icedtea-8:jdk does work fine.  (I'm running boot-clj, a clojure build
tool.)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#28315] [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE.
  2017-09-09  3:48   ` 宋文武
@ 2017-09-10 12:54     ` Ludovic Courtès
  2017-09-11 11:11       ` bug#28315: " 宋文武
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-09-10 12:54 UTC (permalink / raw)
  To: 宋文武; +Cc: 28315

iyzsong@member.fsf.org (宋文武) skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Hello!
>>
>> 宋文武 <iyzsong@member.fsf.org> skribis:
>>
>>> * gnu/packages/java.scm (icedtea-8)[arguments]: Copy 'nss.cfg' from JDK into
>>> JRE in the install phase.
>>
>> What effect does this have?
>
> Before this, accessing HTTPS using the 'java' from icedtea-8 will throw
> an exception about nss.cfg not available, while the 'java' from
> icedtea-8:jdk does work fine.  (I'm running boot-clj, a clojure build
> tool.)

Oh I see.  Maybe just add a comment saying what this file is used for.

LGTM, thanks for explaining!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#28315: [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE.
  2017-09-10 12:54     ` Ludovic Courtès
@ 2017-09-11 11:11       ` 宋文武
  0 siblings, 0 replies; 5+ messages in thread
From: 宋文武 @ 2017-09-11 11:11 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 28315-done

ludo@gnu.org (Ludovic Courtès) writes:

>
> Oh I see.  Maybe just add a comment saying what this file is used for.

Done, thanks for the review!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-09-11 11:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-01 14:14 [bug#28315] [PATCH] gnu: icedtea-8: Install the nss.cfg file to JRE 宋文武
2017-09-04 14:25 ` Ludovic Courtès
2017-09-09  3:48   ` 宋文武
2017-09-10 12:54     ` Ludovic Courtès
2017-09-11 11:11       ` bug#28315: " 宋文武

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).