unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: sharlatanus@gmail.com, 30283@debbugs.gnu.org
Subject: [bug#30283] [PATCH] etc: Add installation script.
Date: Mon, 29 Jan 2018 15:21:43 +0100	[thread overview]
Message-ID: <87inbkn3t4.fsf@gnu.org> (raw)
In-Reply-To: <20180128221740.4401-1-rekado@elephly.net> (Ricardo Wurmus's message of "Sun, 28 Jan 2018 23:17:40 +0100")

Hello!

Ricardo Wurmus <rekado@elephly.net> skribis:

> * etc/guix-install.sh: New file.
> * Makefile.am (EXTRA_DIST): Add it.
>
> Co-authored-by: sharlatan <sharlatanus@gmail.com>

Looks really cool!  We’d need a bit of documentation though, under
“Binary Installation” maybe?

> +sys_authorize_build_farms()
> +{ # authorize the public keys of the two build farms
> +    _msg "${INF}Authorizing build farm public keys"
> +    guix archive --authorize < ~root/.guix-profile/share/guix/hydra.gnu.org.pub &&
> +        _msg "${PAS}Authorized hydra.gnu.org"
> +    guix archive --authorize < ~root/.guix-profile/share/guix/berlin.guixsd.org.pub &&
> +        _msg "${PAS}Authorized berlin.guixsd.org"
> +}

Would it make sense to ask for confirmation?  Like:

  echo "Do you want to authorize binaries from the project's build farms?"
  echo "If you answer yes, Guix will download pre-built package binaries from them."
  echo "If you answer no, Guix will build software from source."
  read -r ANSWER
  case "$ANSWER"
     …
  esac

?

Otherwise LGTM, thanks!

Ludo’.

  reply	other threads:[~2018-01-29 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-28 22:17 [bug#30283] [PATCH] etc: Add installation script Ricardo Wurmus
2018-01-29 14:21 ` Ludovic Courtès [this message]
2018-01-30  2:49   ` Ricardo Wurmus
2018-01-30 11:00     ` bug#30283: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inbkn3t4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30283@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).