From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1egAK4-0003MM-HG
	for guix-patches@gnu.org; Mon, 29 Jan 2018 09:22:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1egAJu-00084O-Qd
	for guix-patches@gnu.org; Mon, 29 Jan 2018 09:22:12 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:39314)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1egAJu-00084D-Mq
	for guix-patches@gnu.org; Mon, 29 Jan 2018 09:22:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1egAJu-00024w-Fr
	for guix-patches@gnu.org; Mon, 29 Jan 2018 09:22:02 -0500
Subject: [bug#30283] [PATCH] etc: Add installation script.
Resent-Message-ID: <handler.30283.B30283.15172357097971@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180128221740.4401-1-rekado@elephly.net>
Date: Mon, 29 Jan 2018 15:21:43 +0100
In-Reply-To: <20180128221740.4401-1-rekado@elephly.net> (Ricardo Wurmus's
	message of "Sun, 28 Jan 2018 23:17:40 +0100")
Message-ID: <87inbkn3t4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: sharlatanus@gmail.com, 30283@debbugs.gnu.org

Hello!

Ricardo Wurmus <rekado@elephly.net> skribis:

> * etc/guix-install.sh: New file.
> * Makefile.am (EXTRA_DIST): Add it.
>
> Co-authored-by: sharlatan <sharlatanus@gmail.com>

Looks really cool!  We=E2=80=99d need a bit of documentation though, under
=E2=80=9CBinary Installation=E2=80=9D maybe?

> +sys_authorize_build_farms()
> +{ # authorize the public keys of the two build farms
> +    _msg "${INF}Authorizing build farm public keys"
> +    guix archive --authorize < ~root/.guix-profile/share/guix/hydra.gnu.=
org.pub &&
> +        _msg "${PAS}Authorized hydra.gnu.org"
> +    guix archive --authorize < ~root/.guix-profile/share/guix/berlin.gui=
xsd.org.pub &&
> +        _msg "${PAS}Authorized berlin.guixsd.org"
> +}

Would it make sense to ask for confirmation?  Like:

  echo "Do you want to authorize binaries from the project's build farms?"
  echo "If you answer yes, Guix will download pre-built package binaries fr=
om them."
  echo "If you answer no, Guix will build software from source."
  read -r ANSWER
  case "$ANSWER"
     =E2=80=A6
  esac

?

Otherwise LGTM, thanks!

Ludo=E2=80=99.