* [bug#33290] [PATCH 3/8] gnu: go-gopkg.in-asn1-ber.v1: Disable tests for go-1.11.
2018-11-06 17:37 ` [bug#33290] [PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: " Pierre Neidhardt
@ 2018-11-06 17:37 ` Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 4/8] gnu: go-github-com-wtolson-go-taglib: " Pierre Neidhardt
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Pierre Neidhardt @ 2018-11-06 17:37 UTC (permalink / raw)
To: 33290
* gnu/packages/syncthing.scm (go-gopkg.in-asn1-ber.v1): Disable tests for go-1.11.
---
gnu/packages/syncthing.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 3c5034057..0d6846cde 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -1257,7 +1257,10 @@ Prometheus HTTP API.")
"1y8bvzbxpw0lfnn7pbcdwzqj4l90qj6xf88dvv9pxd9yl5g6cskx"))))
(build-system go-build-system)
(arguments
- '(#:import-path "gopkg.in/asn1-ber.v1"))
+ '(#:import-path "gopkg.in/asn1-ber.v1"
+ ;; Tests don't pass on go-1.11. See
+ ;; https://github.com/go-asn1-ber/asn1-ber/issues/20.
+ #:tests? #f))
(synopsis "ASN.1 BER encoding and decoding in Go")
(description "This package provides ASN.1 BER encoding and decoding in the
Go language.")
--
2.19.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#33290] [PATCH 4/8] gnu: go-github-com-wtolson-go-taglib: Disable tests for go-1.11.
2018-11-06 17:37 ` [bug#33290] [PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: " Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 3/8] gnu: go-gopkg.in-asn1-ber.v1: " Pierre Neidhardt
@ 2018-11-06 17:37 ` Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 5/8] gnu: go-gitlab-com-ambrevar-golua-unicode: Add workaround " Pierre Neidhardt
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Pierre Neidhardt @ 2018-11-06 17:37 UTC (permalink / raw)
To: 33290
* gnu/packages/golang.scm (go-github-com-wtolson-go-taglib): Disable tests for go-1.11.
---
gnu/packages/golang.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e49372d43..a4978af2a 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2423,7 +2423,10 @@ and lookup requests. Browse requests are not supported yet.")
`(("pkg-config" ,pkg-config)
("taglib" ,taglib)))
(arguments
- `(#:import-path "github.com/wtolson/go-taglib"))
+ `(#:import-path "github.com/wtolson/go-taglib"
+ ;; Tests are broken on go-1.11:
+ ;; https://github.com/wtolson/go-taglib/issues/12.
+ #:tests? #f))
(home-page "https://github.com/wtolson/go-taglib")
(synopsis "Go wrapper for taglib")
(description "Go wrapper for taglib")
--
2.19.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#33290] [PATCH 5/8] gnu: go-gitlab-com-ambrevar-golua-unicode: Add workaround for go-1.11.
2018-11-06 17:37 ` [bug#33290] [PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: " Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 3/8] gnu: go-gopkg.in-asn1-ber.v1: " Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 4/8] gnu: go-github-com-wtolson-go-taglib: " Pierre Neidhardt
@ 2018-11-06 17:37 ` Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 6/8] gnu: go-github-com-stevedonovan-luar: " Pierre Neidhardt
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Pierre Neidhardt @ 2018-11-06 17:37 UTC (permalink / raw)
To: 33290
* gnu/packages/golang.scm (go-gitlab-com-ambrevar-golua-unicode): Add workaround for go-1.11.
---
gnu/packages/golang.scm | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index a4978af2a..b6b726019 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2204,10 +2204,23 @@ run a Lua virtual machine.")
#:import-path "gitlab.com/ambrevar/golua/unicode"
#:phases
(modify-phases %standard-phases
+ ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+ ;; rebuilt (https://bugs.gnu.org/32919). Thus we need to re-specify
+ ;; the special flags of golua here and in the 'check phase below.
+ (replace 'build
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "install"
+ "-v" ; print the name of packages as they are compiled
+ "-x" ; print each command as it is invoked
+ "-ldflags=-s -w" ; strip the symbol table and debug
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path)))
(replace 'check
(lambda* (#:key import-path #:allow-other-keys)
(setenv "USER" "homeless-dude")
- (invoke "go" "test" import-path))))))
+ (invoke "go" "test"
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path))))))
(home-page "https://gitlab.com/ambrevar/golua")
(synopsis "Add Unicode support to Golua")
(description "This extension to Arzilli's Golua adds Unicode support to
--
2.19.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#33290] [PATCH 6/8] gnu: go-github-com-stevedonovan-luar: Add workaround for go-1.11.
2018-11-06 17:37 ` [bug#33290] [PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: " Pierre Neidhardt
` (2 preceding siblings ...)
2018-11-06 17:37 ` [bug#33290] [PATCH 5/8] gnu: go-gitlab-com-ambrevar-golua-unicode: Add workaround " Pierre Neidhardt
@ 2018-11-06 17:37 ` Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 7/8] gnu: demlo: " Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 8/8] gnu: go: Update default to 1.11 Pierre Neidhardt
5 siblings, 0 replies; 10+ messages in thread
From: Pierre Neidhardt @ 2018-11-06 17:37 UTC (permalink / raw)
To: 33290
* gnu/packages/golang.scm (go-github-com-stevedonovan-luar): Add workaround for go-1.11.
---
gnu/packages/golang.scm | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index b6b726019..643ecda9f 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2303,10 +2303,24 @@ similar word.")
"1acjgw9cz1l0l9mzkyk7irz6cfk31wnxgbwa805fvm1rqcjzin2c"))))
(build-system go-build-system)
(native-inputs
- `(("go-github-com-aarzilli-golua" ,go-github-com-aarzilli-golua)))
+ `(("go-github-com-aarzilli-golua" ,go-github-com-aarzilli-golua)
+ ("lua" ,lua)))
(arguments
`(#:tests? #f ; Upstream tests are broken.
- #:import-path "github.com/stevedonovan/luar"))
+ #:import-path "github.com/stevedonovan/luar"
+ ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+ ;; rebuilt (https://bugs.gnu.org/32919). Thus we need to re-specify
+ ;; the special flags of golua and the "lua" native-input.
+ #:phases
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "install"
+ "-v" ; print the name of packages as they are compiled
+ "-x" ; print each command as it is invoked
+ "-ldflags=-s -w" ; strip the symbol table and debug
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path))))))
(home-page "https://github.com/stevedonovan/luar")
(synopsis "Lua reflection bindings for Go")
(description "Luar is designed to make using Lua from Go more
--
2.19.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#33290] [PATCH 7/8] gnu: demlo: Add workaround for go-1.11.
2018-11-06 17:37 ` [bug#33290] [PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: " Pierre Neidhardt
` (3 preceding siblings ...)
2018-11-06 17:37 ` [bug#33290] [PATCH 6/8] gnu: go-github-com-stevedonovan-luar: " Pierre Neidhardt
@ 2018-11-06 17:37 ` Pierre Neidhardt
2018-11-06 17:37 ` [bug#33290] [PATCH 8/8] gnu: go: Update default to 1.11 Pierre Neidhardt
5 siblings, 0 replies; 10+ messages in thread
From: Pierre Neidhardt @ 2018-11-06 17:37 UTC (permalink / raw)
To: 33290
* gnu/packages/music.scm (demlo): Add workaround for go-1.11.
---
gnu/packages/music.scm | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index cdd06647e..bbdf58b18 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4235,7 +4235,10 @@ console music players.")
("go-github-com-michiwend-gomusicbrainz" ,go-github-com-michiwend-gomusicbrainz)
("go-github-com-stevedonovan-luar" ,go-github-com-stevedonovan-luar)
("go-github-com-wtolson-go-taglib" ,go-github-com-wtolson-go-taglib)
- ("go-github-com-yookoala-realpath" ,go-github-com-yookoala-realpath)))
+ ("go-github-com-yookoala-realpath" ,go-github-com-yookoala-realpath)
+ ;; Those should not be needed, see TODO below.
+ ("pkg-config" ,pkg-config)
+ ("taglib" ,taglib)))
(inputs
`(("chromaprint" ,chromaprint)
("ffmpeg" ,ffmpeg)))
@@ -4243,6 +4246,23 @@ console music players.")
`(#:import-path "gitlab.com/ambrevar/demlo"
#:phases
(modify-phases %standard-phases
+ ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+ ;; rebuilt (https://bugs.gnu.org/32919). Thus we need to
+ ;; re-specify the special flags of golua, the pkg-config + taglib
+ ;; native-inputs, and the 'check phase below.
+ (replace 'build
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "install"
+ "-v" ; print the name of packages as they are compiled
+ "-x" ; print each command as it is invoked
+ "-ldflags=-s -w" ; strip the symbol table and debug
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path)))
+ (replace 'check
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "test"
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path)))
(add-after 'install 'wrap-program
(lambda* (#:key inputs outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out"))
--
2.19.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#33290] [PATCH 8/8] gnu: go: Update default to 1.11.
2018-11-06 17:37 ` [bug#33290] [PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: " Pierre Neidhardt
` (4 preceding siblings ...)
2018-11-06 17:37 ` [bug#33290] [PATCH 7/8] gnu: demlo: " Pierre Neidhardt
@ 2018-11-06 17:37 ` Pierre Neidhardt
5 siblings, 0 replies; 10+ messages in thread
From: Pierre Neidhardt @ 2018-11-06 17:37 UTC (permalink / raw)
To: 33290
* gnu/packages/golang.scm (go): Update default to 1.11.
---
gnu/packages/golang.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 643ecda9f..77f854b55 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -528,7 +528,7 @@ in the style of communicating sequential processes (@dfn{CSP}).")
(setenv "GOGC" "400")
#t)))))))))
-(define-public go go-1.9)
+(define-public go go-1.11)
(define-public go-github-com-alsm-ioprogress
(let ((commit "063c3725f436e7fba0c8f588547bee21ffec7ac5")
--
2.19.1
^ permalink raw reply related [flat|nested] 10+ messages in thread