unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37317] [PATCH] Add emacs-flyspell-grammalecte
@ 2019-09-05 23:11 Nicolas Goaziou
  2019-09-06  7:09 ` Nicolas Goaziou
  2019-09-26 21:11 ` Ludovic Courtès
  0 siblings, 2 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2019-09-05 23:11 UTC (permalink / raw)
  To: 37317

[-- Attachment #1: Type: text/plain, Size: 111 bytes --]

Hello,

The following patch adds emacs-flyspell-grammalecte.

Feedback welcome.

Regards,

-- 
Nicolas Goaziou

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add emacs-flyspell-grammalecte --]
[-- Type: text/x-diff, Size: 3588 bytes --]

From d362da36f369d0bf98d49c484ce9fd6b0603b5b2 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Fri, 6 Sep 2019 01:10:10 +0200
Subject: [PATCH] gnu: Add emacs-flycheck-grammalecte.

* gnu/packages/emacs-xyz.scm (emacs-flycheck-grammalecte): New variable.
---
 gnu/packages/emacs-xyz.scm | 54 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8f866fbc28..7ca3f8e4ca 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -88,6 +88,7 @@
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages code)
   #:use-module (gnu packages databases)
+  #:use-module (gnu packages dictionaries)
   #:use-module (gnu packages emacs)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
@@ -3076,6 +3077,59 @@ boundaries defined by syntax highlighting.")
 for Flow files.")
       (license license:gpl3+))))
 
+(define-public emacs-flycheck-grammalecte
+  (package
+    (name "emacs-flycheck-grammalecte")
+    (version "0.9")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://git.deparis.io/"
+                                  "flycheck-grammalecte/snapshot/"
+                                  "flycheck-grammalecte-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0wjm9xyra870pci4bcrbnc9x66x18mi7iz08rkxa4clxv28xzryb"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:include '("\\.(el|py)$")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-python
+           ;; Hardcode python3 executable in the Emacs library.
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((python3 (string-append (assoc-ref inputs "python")
+                                           "/bin/python3")))
+               (substitute* "flycheck-grammalecte.el"
+                 (("python3") python3))
+               #t)))
+         (add-after 'install 'link-to-grammalecte
+           ;; The package expects grammalecte to be in a sub-directory.
+           ;; Symlink it there from the store.
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((grammalecte (assoc-ref inputs "grammalecte"))
+                   (out (assoc-ref outputs "out"))
+                   (version ,(version-major+minor (package-version python))))
+               (with-directory-excursion
+                   (string-append out
+                                  "/share/emacs/site-lisp/guix.d/"
+                                  "flycheck-grammalecte-" ,version)
+                 (symlink (string-append grammalecte "/lib/"
+                                         "python" version "/site-packages/"
+                                         "grammalecte")
+                          "grammalecte"))))))))
+    (inputs
+     `(("grammalecte" ,grammalecte)
+       ("python" ,python)))
+    (propagated-inputs
+     `(("emacs-flycheck" ,emacs-flycheck)))
+    (home-page "https://git.deparis.io/flycheck-grammalecte/")
+    (synopsis "Integrate Grammalecte with Flycheck")
+    (description "Integrate the French grammar and typography checker
+Grammalecte with Flycheck to automatically look for mistakes in your
+writings. It also provides an easy way to find synonyms and antonyms for
+a given word (to avoid repetitions for example).")
+    (license license:gpl3+)))
+
 (define-public emacs-elisp-demos
   (package
     (name "emacs-elisp-demos")
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#37317] [PATCH] Add emacs-flyspell-grammalecte
  2019-09-05 23:11 [bug#37317] [PATCH] Add emacs-flyspell-grammalecte Nicolas Goaziou
@ 2019-09-06  7:09 ` Nicolas Goaziou
  2019-09-26 21:11 ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2019-09-06  7:09 UTC (permalink / raw)
  To: 37317

Completing myself,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> +         (add-after 'install 'link-to-grammalecte
> +           ;; The package expects grammalecte to be in a sub-directory.
> +           ;; Symlink it there from the store.
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((grammalecte (assoc-ref inputs "grammalecte"))
> +                   (out (assoc-ref outputs "out"))
> +                   (version ,(version-major+minor (package-version python))))
> +               (with-directory-excursion
> +                   (string-append out
> +                                  "/share/emacs/site-lisp/guix.d/"
> +                                  "flycheck-grammalecte-" ,version)
> +                 (symlink (string-append grammalecte "/lib/"
> +                                         "python" version "/site-packages/"
> +                                         "grammalecte")
> +                          "grammalecte"))))))))

I forgot a #t here. I'll add it. I'm not sending the updated patch.

> +    (inputs
> +     `(("grammalecte" ,grammalecte)
> +       ("python" ,python)))
> +    (propagated-inputs
> +     `(("emacs-flycheck" ,emacs-flycheck)))
> +    (home-page "https://git.deparis.io/flycheck-grammalecte/")
> +    (synopsis "Integrate Grammalecte with Flycheck")
> +    (description "Integrate the French grammar and typography checker
> +Grammalecte with Flycheck to automatically look for mistakes in your
> +writings. It also provides an easy way to find synonyms and antonyms for

Missing space here. Also fixed.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#37317] [PATCH] Add emacs-flyspell-grammalecte
  2019-09-05 23:11 [bug#37317] [PATCH] Add emacs-flyspell-grammalecte Nicolas Goaziou
  2019-09-06  7:09 ` Nicolas Goaziou
@ 2019-09-26 21:11 ` Ludovic Courtès
  2019-09-27 19:48   ` bug#37317: " Nicolas Goaziou
  1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-09-26 21:11 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 37317

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

>>From d362da36f369d0bf98d49c484ce9fd6b0603b5b2 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Fri, 6 Sep 2019 01:10:10 +0200
> Subject: [PATCH] gnu: Add emacs-flycheck-grammalecte.
>
> * gnu/packages/emacs-xyz.scm (emacs-flycheck-grammalecte): New variable.

LGTM, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#37317: [PATCH] Add emacs-flyspell-grammalecte
  2019-09-26 21:11 ` Ludovic Courtès
@ 2019-09-27 19:48   ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2019-09-27 19:48 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 37317-done

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> LGTM, thanks!

Applied. Thank you!

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-09-27 19:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 23:11 [bug#37317] [PATCH] Add emacs-flyspell-grammalecte Nicolas Goaziou
2019-09-06  7:09 ` Nicolas Goaziou
2019-09-26 21:11 ` Ludovic Courtès
2019-09-27 19:48   ` bug#37317: " Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).