* [bug#38400] [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
@ 2019-11-27 10:49 Pierre Langlois
2019-11-27 23:36 ` bug#38400: " Marius Bakke
0 siblings, 1 reply; 2+ messages in thread
From: Pierre Langlois @ 2019-11-27 10:49 UTC (permalink / raw)
To: 38400
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
Hello Guix!
Since we updated imlib2 to version 1.6 the feh test suite was failing,
however it looks harmless. The output expectation just needs tweaking a
little.
I've reported it upstream https://github.com/derf/feh/issues/497 but in
the meantime, here's a patch for downstream! I don't think such a patch
is suitable upstream as it would mean the tests would fail on previous
versions of imlib2.
[-- Attachment #2: 0001-gnu-feh-Adapt-tests-for-imlib2-1.6.patch --]
[-- Type: text/x-patch, Size: 4508 bytes --]
From 1355d070a0d6dbe598e7feb4457da6ea988921e8 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Wed, 27 Nov 2019 10:40:56 +0000
Subject: [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
* gnu/packages/patches/feh-fix-tests-for-imlib2-1.6.patch: New file.
* gnu/packages/image-viewers.scm (feh)[source]: Use it.
* gnu/local.mk (dist_patch_DATA): Add it.
---
gnu/local.mk | 1 +
gnu/packages/image-viewers.scm | 5 +-
.../feh-fix-tests-for-imlib2-1.6.patch | 51 +++++++++++++++++++
3 files changed, 56 insertions(+), 1 deletion(-)
create mode 100644 gnu/packages/patches/feh-fix-tests-for-imlib2-1.6.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 0129e42944..082465a24a 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -826,6 +826,7 @@ dist_patch_DATA = \
%D%/packages/patches/fbreader-curl-7.62.patch \
%D%/packages/patches/fcgi-2.4.0-gcc44-fixes.patch \
%D%/packages/patches/fcgi-2.4.0-poll.patch \
+ %D%/packages/patches/feh-fix-tests-for-imlib2-1.6.patch \
%D%/packages/patches/fifo-map-fix-flags-for-gcc.patch \
%D%/packages/patches/fifo-map-remove-catch.hpp.patch \
%D%/packages/patches/file-CVE-2018-10360.patch \
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index d237a27c4a..c0300f5087 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -11,6 +11,7 @@
;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
;;; Copyright © 2019 Guy Fleury Iteriteka <hoonandon@gmail.com>
+;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -72,7 +73,9 @@
name "-" version ".tar.bz2"))
(sha256
(base32
- "070axq8jpibcabmjfv4fmjmpk3k349vzvh4qhsi4n62bkcwl35wg"))))
+ "070axq8jpibcabmjfv4fmjmpk3k349vzvh4qhsi4n62bkcwl35wg"))
+ (patches
+ (search-patches "feh-fix-tests-for-imlib2-1.6.patch"))))
(build-system gnu-build-system)
(arguments
'(#:phases (modify-phases %standard-phases (delete 'configure))
diff --git a/gnu/packages/patches/feh-fix-tests-for-imlib2-1.6.patch b/gnu/packages/patches/feh-fix-tests-for-imlib2-1.6.patch
new file mode 100644
index 0000000000..a91906dbe9
--- /dev/null
+++ b/gnu/packages/patches/feh-fix-tests-for-imlib2-1.6.patch
@@ -0,0 +1,51 @@
+commit 8048fb542d0c36f868760ba1590fbe14a3a85df7
+Author: Pierre Langlois <pierre.langlois@gmx.com>
+Date: Wed Nov 27 10:42:05 2019 +0000
+
+ Adapt tests for imlib2 1.6
+
+ Reported upstream on https://github.com/derf/feh/issues/497
+
+diff --git a/test/list/custom b/test/list/custom
+index dbe2074..40ac557 100644
+--- a/test/list/custom
++++ b/test/list/custom
+@@ -1,4 +1,4 @@
+ test/ok/gif; 16; 4; list; gif; 256; 953; gif; 1; 16
+-test/ok/jpg; 16; 4; list; jpg; 256; 354; jpeg; 2; 16
++test/ok/jpg; 16; 4; list; jpg; 256; 354; jpg; 2; 16
+ test/ok/png; 16; 4; list; png; 256; 403; png; 3; 16
+ test/ok/pnm; 16; 4; list; pnm; 256; 269; pnm; 4; 16
+diff --git a/test/list/default b/test/list/default
+index bc0ef52..e480db3 100644
+--- a/test/list/default
++++ b/test/list/default
+@@ -1,5 +1,5 @@
+ NUM FORMAT WIDTH HEIGHT PIXELS SIZE ALPHA FILENAME
+ 1 gif 16 16 256 953 - test/ok/gif
+-2 jpeg 16 16 256 354 - test/ok/jpg
++2 jpg 16 16 256 354 - test/ok/jpg
+ 3 png 16 16 256 403 X test/ok/png
+ 4 pnm 16 16 256 269 - test/ok/pnm
+diff --git a/test/list/format_reverse b/test/list/format_reverse
+index 9216184..3301f78 100644
+--- a/test/list/format_reverse
++++ b/test/list/format_reverse
+@@ -1,5 +1,5 @@
+ NUM FORMAT WIDTH HEIGHT PIXELS SIZE ALPHA FILENAME
+ 1 pnm 16 16 256 269 - test/ok/pnm
+ 2 png 16 16 256 403 X test/ok/png
+-3 jpeg 16 16 256 354 - test/ok/jpg
++3 jpg 16 16 256 354 - test/ok/jpg
+ 4 gif 16 16 256 953 - test/ok/gif
+diff --git a/test/list/size b/test/list/size
+index cad60b0..7716239 100644
+--- a/test/list/size
++++ b/test/list/size
+@@ -1,5 +1,5 @@
+ NUM FORMAT WIDTH HEIGHT PIXELS SIZE ALPHA FILENAME
+ 1 pnm 16 16 256 269 - test/ok/pnm
+-2 jpeg 16 16 256 354 - test/ok/jpg
++2 jpg 16 16 256 354 - test/ok/jpg
+ 3 png 16 16 256 403 X test/ok/png
+ 4 gif 16 16 256 953 - test/ok/gif
--
2.24.0
[-- Attachment #3: Type: text/plain, Size: 16 bytes --]
Thanks,
Pierre
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#38400: [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
2019-11-27 10:49 [bug#38400] [PATCH] gnu: feh: Adapt tests for imlib2 1.6 Pierre Langlois
@ 2019-11-27 23:36 ` Marius Bakke
0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2019-11-27 23:36 UTC (permalink / raw)
To: Pierre Langlois, 38400-done
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
Pierre Langlois <pierre.langlois@gmx.com> writes:
> Hello Guix!
>
> Since we updated imlib2 to version 1.6 the feh test suite was failing,
> however it looks harmless. The output expectation just needs tweaking a
> little.
>
> I've reported it upstream https://github.com/derf/feh/issues/497 but in
> the meantime, here's a patch for downstream! I don't think such a patch
> is suitable upstream as it would mean the tests would fail on previous
> versions of imlib2.
Thanks! Pushed in 9943d238e9f07dccae973b641eb7738637ce95fb.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-27 23:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 10:49 [bug#38400] [PATCH] gnu: feh: Adapt tests for imlib2 1.6 Pierre Langlois
2019-11-27 23:36 ` bug#38400: " Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).