From: Marius Bakke <marius@gnu.org>
To: Vinicius Monego <monego@posteo.net>, 43883@debbugs.gnu.org
Cc: Vinicius Monego <monego@posteo.net>
Subject: [bug#43883] [PATCH] gnu: Add libebur128.
Date: Tue, 13 Oct 2020 23:15:20 +0200 [thread overview]
Message-ID: <87imbdrfo7.fsf@gnu.org> (raw)
In-Reply-To: <20201009151256.7949-1-monego@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
Vinicius Monego <monego@posteo.net> writes:
> * gnu/packages/audio.scm (libebur128): New variable.
[...]
> + (arguments
> + `(;; Tests require .wav files that are not distributed with the code.
> + ;; See https://github.com/jiixyj/libebur128/issues/82.
> + #:tests? #f
It is easy to provide these data files using an (origin ...) in
native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check
the terms of use first, as the data set is unrelated to this package.
(I don't really have a strong opinion here, just sayin')
> + #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
Note: you can use #:build-type "Release" instead. The default is
"RelWithDebInfo", so it's customary to add a comment when changing it.
Is there a particular reason to not provide debugging information here?
Otherwise the patch LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2020-10-13 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:12 [bug#43883] [PATCH] gnu: Add libebur128 Vinicius Monego
2020-10-13 21:15 ` Marius Bakke [this message]
2020-10-15 23:56 ` Vinicius Monego
2020-10-18 21:59 ` bug#43883: " Marius Bakke
2020-10-16 14:21 ` [bug#43883] [PATCH v2] " Vinicius Monego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbdrfo7.fsf@gnu.org \
--to=marius@gnu.org \
--cc=43883@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).