From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wBZ0ACkZhl9gZgAA0tVLHw (envelope-from ) for ; Tue, 13 Oct 2020 21:16:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aDj/NygZhl8nQwAA1q6Kng (envelope-from ) for ; Tue, 13 Oct 2020 21:16:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 843F89402A6 for ; Tue, 13 Oct 2020 21:16:24 +0000 (UTC) Received: from localhost ([::1]:37502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSReh-0006Cn-Ca for larch@yhetil.org; Tue, 13 Oct 2020 17:16:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSReM-0006BZ-0Z for guix-patches@gnu.org; Tue, 13 Oct 2020 17:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSReL-0006PS-N8 for guix-patches@gnu.org; Tue, 13 Oct 2020 17:16:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSReL-0003cI-Ir for guix-patches@gnu.org; Tue, 13 Oct 2020 17:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43883] [PATCH] gnu: Add libebur128. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Oct 2020 21:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego , 43883@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 43883-submit@debbugs.gnu.org id=B43883.160262373213864 (code B ref 43883); Tue, 13 Oct 2020 21:16:01 +0000 Received: (at 43883) by debbugs.gnu.org; 13 Oct 2020 21:15:32 +0000 Received: from localhost ([127.0.0.1]:49085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSRdr-0003bY-PA for submit@debbugs.gnu.org; Tue, 13 Oct 2020 17:15:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSRdp-0003bL-TA for 43883@debbugs.gnu.org; Tue, 13 Oct 2020 17:15:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44318) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSRdk-0006Dw-Ec; Tue, 13 Oct 2020 17:15:24 -0400 Received: from ti0006q161-1594.bb.online.no ([46.9.75.77]:51842 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSRdj-000201-NR; Tue, 13 Oct 2020 17:15:24 -0400 From: Marius Bakke In-Reply-To: <20201009151256.7949-1-monego@posteo.net> References: <20201009151256.7949-1-monego@posteo.net> Date: Tue, 13 Oct 2020 23:15:20 +0200 Message-ID: <87imbdrfo7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: hMVRnFwXNYJv --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > * gnu/packages/audio.scm (libebur128): New variable. [...] =20=20 > + (arguments > + `(;; Tests require .wav files that are not distributed with the cod= e. > + ;; See https://github.com/jiixyj/libebur128/issues/82. > + #:tests? #f It is easy to provide these data files using an (origin ...) in native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check the terms of use first, as the data set is unrelated to this package. (I don't really have a strong opinion here, just sayin') > + #:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease" Note: you can use #:build-type "Release" instead. The default is "RelWithDebInfo", so it's customary to add a comment when changing it. Is there a particular reason to not provide debugging information here? Otherwise the patch LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+GGOgPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT6NrsH/RwUpkDiUk6TiwHL7Ed/pXJfVscTmVp/3CvU HOGiHctftsyf9c/8pEAkMnQO7df4QudJ2v4P4s71JrOD9xytUP9sL+bRIAbBEqba NADmW+cppqU2Iu5BkNzWvkExjuftZSjoeYg7EL4XIsVOM4otxwRzBrx47dyQ4F4N tYy06kF5lI48gAnf/CaFNktJHjHw1Hv0NMyTM1KW5iarbjePI0GuPhbXkalUq0Jl VX9jZTLqJZSH++ZIewww2a0CEQQ8nVCs4gWMf+MjvPd7Jgt3ZJhojDDI8V2XaU9y 9jDWNCarpBamoVjK6jEv8gvClHS9FU6Wb+/pVgpHtAm9bSn//tY= =35UP -----END PGP SIGNATURE----- --=-=-=--