unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 57861@debbugs.gnu.org, Lars-Dominik Braun <lars@6xq.net>
Subject: [bug#57861] [PATCH] gnu: Add ultrastar-deluxe.
Date: Mon, 17 Oct 2022 18:44:21 +0200	[thread overview]
Message-ID: <87ilkipfh6.fsf@gnu.org> (raw)
In-Reply-To: <4cdb853b-accb-02a5-5f39-e14994dfcb8d@telenet.be> (Maxime Devos's message of "Mon, 17 Oct 2022 15:25:52 +0200")

Maxime Devos <maximedevos@telenet.be> skribis:

> On 17-10-2022 10:33, Ludovic Courtès wrote:
>> Hello!
>> Lars-Dominik Braun <lars@6xq.net> skribis:
>> 
>>> +;; Lazily resolve to avoid a circular dependency.
>>> +(define fpc*
>>> +  (delay (module-ref (resolve-interface '(gnu packages pascal))
>>> +                     'fpc)))
>> I think this is unnecessary: you can just #:use-module (gnu packages
>> pascal) and have ‘fpc’ in ‘native-inputs’.  Everything will be fine
>> because ‘inputs’ is a thunked field (IOW, its evaluation is delayed).
>
> That's still a circular dependency.  Why import (gnu packages pascal)
> when you don't need it

That’s what every package module does.

We can discuss the drawbacks of this and ways to avoid it, but this
particular patch and review is not the right place to do that IMO.

Thanks,
Ludo’.




  parent reply	other threads:[~2022-10-17 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 13:37 [bug#57861] [PATCH] gnu: Add ultrastar-deluxe Lars-Dominik Braun
2022-09-18  9:39 ` Maxime Devos
2022-09-21 11:52   ` [bug#57861] [PATCH v2] " Lars-Dominik Braun
2022-10-17  8:33     ` [bug#57861] [PATCH] " Ludovic Courtès
2022-10-17 13:25       ` Maxime Devos
2022-10-17 13:28         ` ( via Guix-patches via
2022-10-17 13:37           ` Maxime Devos
2022-10-17 16:44         ` Ludovic Courtès [this message]
2022-10-17 17:26           ` Maxime Devos
2022-10-17  8:35     ` Ludovic Courtès
2022-10-18  7:56       ` Lars-Dominik Braun
2022-10-18 12:44         ` Maxime Devos
2022-10-19 11:09           ` [bug#57861] [PATCH v2] " Lars-Dominik Braun
2022-11-07 22:59             ` bug#57861: [PATCH] " Ludovic Courtès
2022-10-18 12:49         ` [bug#57861] " Maxime Devos
2022-09-18 12:26 ` Maxime Devos
2022-11-07 21:41 ` Jonathan Brielmaier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilkipfh6.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=57861@debbugs.gnu.org \
    --cc=lars@6xq.net \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).