From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ABjpF6aGTWMM6AAAbAwnHQ (envelope-from ) for ; Mon, 17 Oct 2022 18:45:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uC78F6aGTWPcuQAA9RJhRA (envelope-from ) for ; Mon, 17 Oct 2022 18:45:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F3BD1096D for ; Mon, 17 Oct 2022 18:45:26 +0200 (CEST) Received: from localhost ([::1]:44582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okTEz-00031k-Bp for larch@yhetil.org; Mon, 17 Oct 2022 12:45:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okTEd-0002xw-7X for guix-patches@gnu.org; Mon, 17 Oct 2022 12:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okTEc-00026u-Uw for guix-patches@gnu.org; Mon, 17 Oct 2022 12:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okTEb-0005sB-RI for guix-patches@gnu.org; Mon, 17 Oct 2022 12:45:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57861] [PATCH] gnu: Add ultrastar-deluxe. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Oct 2022 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57861 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 57861@debbugs.gnu.org, Lars-Dominik Braun Received: via spool by 57861-submit@debbugs.gnu.org id=B57861.166602507222510 (code B ref 57861); Mon, 17 Oct 2022 16:45:01 +0000 Received: (at 57861) by debbugs.gnu.org; 17 Oct 2022 16:44:32 +0000 Received: from localhost ([127.0.0.1]:49766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okTE8-0005r0-6z for submit@debbugs.gnu.org; Mon, 17 Oct 2022 12:44:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okTE5-0005qn-Ua for 57861@debbugs.gnu.org; Mon, 17 Oct 2022 12:44:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okTDz-000239-Ik; Mon, 17 Oct 2022 12:44:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=VUdasp4FJYUWkmUWXgLkqiu6Uf5Qp3vRM4PthEA9tKA=; b=aN7pSndtvqmxmP/cwaUy TY3oHag4su9nZdpf41U2/qp9Ty3YksllKDL+zS8+rwkGwDazq7px7Yjljqmgh9UP/pKPv0lhnh5ba usj5kVtsTHmtNOVeSahjwg6iq6/iDZT+DQXp3BaAExAesHT2By3lcRf/aQdnej2TzMcIuUewKXJQE OT+7mYUWplTLCHmHODNkjLCRogGLgi8Q4H0rUySEYPLqaCvn7gldKA2zyWiafk9fNNkEcSxlstQZO FK4cS5y8EXiEOn6AD36ig+pSqDX+A5s2ajmSNcjLFsccQdIIpBkUgIGdWHED1kuL0JDOSLMpNBiID aOl5WY9FTYOyAA==; Received: from [193.50.110.209] (port=59136 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okTDz-0003eX-4v; Mon, 17 Oct 2022 12:44:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87lepehmsw.fsf_-_@gnu.org> <4cdb853b-accb-02a5-5f39-e14994dfcb8d@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 26 =?UTF-8?Q?Vend=C3=A9miaire?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Aubergine X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 17 Oct 2022 18:44:21 +0200 In-Reply-To: <4cdb853b-accb-02a5-5f39-e14994dfcb8d@telenet.be> (Maxime Devos's message of "Mon, 17 Oct 2022 15:25:52 +0200") Message-ID: <87ilkipfh6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666025126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VUdasp4FJYUWkmUWXgLkqiu6Uf5Qp3vRM4PthEA9tKA=; b=iF0LylkxhZmAl3e6qrQaO3DPWoqf89zQWda51Vx3yVuaGOTSQZpmv8lX6u5J4J96TJaFpK 3q//ehjcaDnKIAfzeDPBhwIqdKOzsBMMyQXm3b4UOQsetJ6+1SstqECYO1rzJP1czeYjHb M3KkxZuMSFPvTaW2gA0A+7uaURALQ2EUjFIsToTASJ93U5ESfeuAeFAIyhIlUDT5COMQTr s+k7m2IEt4C+H42qFQ7wmGqzxvsYUXjMrVbCj/J3SJrbFfR0//EEEZSm+0ipG6V9eSeoAN qoqVjuZcYoKmgyeJB9rOyH84l3IaQejKe8gxh7uX93ysfZoO1eZEcvckDNY+lA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666025126; a=rsa-sha256; cv=none; b=rVz48lo7fnUb6hfWkoFEvjCHyc4GUboGolWpy3HOTHCxM2FkvMD2thItRWJgY5o3IA4rym /ZQEwGaa208o92BF8v3XyXK8flx6E9u6XoItpya/mN+oX4yYNKmg1LbhimMNtyk6IIPfJE MP+fpLGmhriCIx93qC7Vw7nKwfx7A8zuvq6dUqrnLJPPzpjVoUokzbXQ0KCOGV3KcD+oOS eGUkGXQnyGUeN3WuxMqzLRN+jN5rU8Ch1a68aW/v9BjyhufXSON2l7q1WEWOc6y7w/BSfS x7psANUYpN4vdpeGprgABXiNeThVzmTTmLZy3mQapE1DEB6AGTMmAgznBaUvBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=aN7pSndt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=aN7pSndt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3F3BD1096D X-Spam-Score: -3.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: TgfMeJcG/xUG Maxime Devos skribis: > On 17-10-2022 10:33, Ludovic Court=C3=A8s wrote: >> Hello! >> Lars-Dominik Braun skribis: >>=20 >>> +;; Lazily resolve to avoid a circular dependency. >>> +(define fpc* >>> + (delay (module-ref (resolve-interface '(gnu packages pascal)) >>> + 'fpc))) >> I think this is unnecessary: you can just #:use-module (gnu packages >> pascal) and have =E2=80=98fpc=E2=80=99 in =E2=80=98native-inputs=E2=80= =99. Everything will be fine >> because =E2=80=98inputs=E2=80=99 is a thunked field (IOW, its evaluation= is delayed). > > That's still a circular dependency. Why import (gnu packages pascal) > when you don't need it That=E2=80=99s what every package module does. We can discuss the drawbacks of this and ways to avoid it, but this particular patch and review is not the right place to do that IMO. Thanks, Ludo=E2=80=99.