* [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
@ 2023-10-17 5:35 Andrew Jose
2023-10-17 8:48 ` Christopher Baines
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrew Jose @ 2023-10-17 5:35 UTC (permalink / raw)
To: 66584; +Cc: Andrew Jose
This commit adds the flexoki-themes package imported from MELPA
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..40773b13ff 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2451,6 +2451,29 @@ (define-public emacs-dante
supports type hints, definition-jumping, completion, and more.")
(license license:gpl3+)))
+(define-public emacs-flexoki-themes
+(package
+ ((name "emacs-flexoki-themes")
+ (version "20231015.2014")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url
+ "https://github.com/crmsnbleyd/flexoki-emacs-theme.git")
+ (commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")))
+ (sha256
+ (base32
+ "18y63cz6brxynz5k7lq9j3jrvz90w6mjqnpaaj3yp7xmr19n7q0y"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+ (synopsis "An inky colour scheme for prose and code")
+ (description
+ "Flexoki-themes is a pair of light and dark themes for GNU Emacs based on
+the Flexoki colour scheme by Steph Ango.")
+ (license licence:gpl3+))))
+
(define-public emacs-flycheck
(package
(name "emacs-flycheck")
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
2023-10-17 5:35 [bug#66584] [PATCH] gnu: add emacs-flexoki-themes Andrew Jose
@ 2023-10-17 8:48 ` Christopher Baines
2023-10-17 9:22 ` Andrew Jose
2023-10-17 14:37 ` Andrew Jose
2 siblings, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2023-10-17 8:48 UTC (permalink / raw)
To: Andrew Jose; +Cc: 66584
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Andrew Jose <arnav.jose@gmail.com> writes:
> This commit adds the flexoki-themes package imported from MELPA
> ---
> gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..40773b13ff 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -2451,6 +2451,29 @@ (define-public emacs-dante
> supports type hints, definition-jumping, completion, and more.")
> (license license:gpl3+)))
>
> +(define-public emacs-flexoki-themes
> +(package
> + ((name "emacs-flexoki-themes")
> + (version "20231015.2014")
The bit above where you've got (package (( looks wrong, have you managed
to build this pacakge locally?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
2023-10-17 5:35 [bug#66584] [PATCH] gnu: add emacs-flexoki-themes Andrew Jose
2023-10-17 8:48 ` Christopher Baines
@ 2023-10-17 9:22 ` Andrew Jose
2023-10-17 9:48 ` Nicolas Goaziou
2023-10-17 14:37 ` Andrew Jose
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Jose @ 2023-10-17 9:22 UTC (permalink / raw)
To: 66584; +Cc: Andrew Jose, mail
imported from melpa
This patch reverts the previous one and also uses the latest ref from MELPA. It is tested to build and I apologise for the previous one, which was indeed wrong
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..b59a3f1321 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2451,6 +2451,29 @@ (define-public emacs-dante
supports type hints, definition-jumping, completion, and more.")
(license license:gpl3+)))
+(define-public emacs-flexoki-themes
+ (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
+ (revision "20231017.501"))
+ (package
+ (name "emacs-flexoki-themes")
+ (version revision)
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "18y63cz6brxynz5k7lq9j3jrvz90w6mjqnpaaj3yp7xmr19n7q0y"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+ (synopsis "An inky colour scheme for prose and code")
+ (description
+ "Flexoki-themes is a pair of light and dark themes for GNU Emacs based on
+the Flexoki colour scheme by Steph Ango.")
+ (license license:gpl3+))))
+
(define-public emacs-flycheck
(package
(name "emacs-flycheck")
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
2023-10-17 9:22 ` Andrew Jose
@ 2023-10-17 9:48 ` Nicolas Goaziou
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2023-10-17 9:48 UTC (permalink / raw)
To: Andrew Jose; +Cc: 66584, mail
Hello,
Andrew Jose <arnav.jose@gmail.com> writes:
> +(define-public emacs-flexoki-themes
Thanks.
> + (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
> + (revision "20231017.501"))
> + (package
> + (name "emacs-flexoki-themes")
> + (version revision)
The version should be "0.12". Guix doesn't follow MELPA numbering, but
rather upstream versioning.
> + (synopsis "An inky colour scheme for prose and code")
The synopsis shouldn't start out with an article, such as "An":
"Inky colour scheme …"
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#66584] [PATCH] gnu: add emacs-flexoki-themes
2023-10-17 5:35 [bug#66584] [PATCH] gnu: add emacs-flexoki-themes Andrew Jose
2023-10-17 8:48 ` Christopher Baines
2023-10-17 9:22 ` Andrew Jose
@ 2023-10-17 14:37 ` Andrew Jose
2024-01-21 23:27 ` bug#66584: " Nicolas Goaziou via Guix-patches via
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Jose @ 2023-10-17 14:37 UTC (permalink / raw)
To: 66584; +Cc: Andrew Jose, mail, mail
This patch invalidates any previous patches sent on this issue.
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb8c25f9b5..e2a546d35d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2451,6 +2451,29 @@ (define-public emacs-dante
supports type hints, definition-jumping, completion, and more.")
(license license:gpl3+)))
+(define-public emacs-flexoki-themes
+ (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
+ (revision "0.12"))
+ (package
+ (name "emacs-flexoki-themes")
+ (version revision)
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "18y63cz6brxynz5k7lq9j3jrvz90w6mjqnpaaj3yp7xmr19n7q0y"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/crmsnbleyd/flexoki-emacs-theme")
+ (synopsis "Inky colour scheme for prose and code")
+ (description
+ "Flexoki-themes is a pair of light and dark themes for GNU Emacs based on
+the Flexoki colour scheme by Steph Ango.")
+ (license license:gpl3+))))
+
(define-public emacs-flycheck
(package
(name "emacs-flycheck")
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#66584: [PATCH] gnu: add emacs-flexoki-themes
2023-10-17 14:37 ` Andrew Jose
@ 2024-01-21 23:27 ` Nicolas Goaziou via Guix-patches via
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-01-21 23:27 UTC (permalink / raw)
To: Andrew Jose; +Cc: 66584-done, mail
Hello,
Andrew Jose <arnav.jose@gmail.com> writes:
> +(define-public emacs-flexoki-themes
> + (let ((commit "4285faa2f6fd95c46b42fa922e3309f6a0ad0711")
> + (revision "0.12"))
Thank you. I applied your patch and bumped version to 0.20.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-21 23:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 5:35 [bug#66584] [PATCH] gnu: add emacs-flexoki-themes Andrew Jose
2023-10-17 8:48 ` Christopher Baines
2023-10-17 9:22 ` Andrew Jose
2023-10-17 9:48 ` Nicolas Goaziou
2023-10-17 14:37 ` Andrew Jose
2024-01-21 23:27 ` bug#66584: " Nicolas Goaziou via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).