* bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
@ 2017-04-02 15:12 Arun Isaac
2017-04-02 17:02 ` Kei Kebreau
2017-04-02 19:20 ` Arun Isaac
0 siblings, 2 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-02 15:12 UTC (permalink / raw)
To: 26342
* gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
---
gnu/packages/emacs.scm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb2792f63..1091e562a 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
(base32
"145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
(build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'check
+ (lambda _
+ (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
+ "--eval" "(add-to-list 'load-path \"./tests\")"
+ "-l" "tests/elfeed-tests.el"
+ "-f" "ert-run-tests-batch-and-exit")))))))
(home-page "https://github.com/skeeto/elfeed")
(synopsis "Atom/RSS feed reader for Emacs")
(description
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
2017-04-02 15:12 bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests Arun Isaac
@ 2017-04-02 17:02 ` Kei Kebreau
2017-04-02 18:57 ` Arun Isaac
2017-04-02 19:20 ` Arun Isaac
1 sibling, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-04-02 17:02 UTC (permalink / raw)
To: Arun Isaac; +Cc: 26342
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
> ---
> gnu/packages/emacs.scm | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index cb2792f63..1091e562a 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
> (base32
> "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
> (build-system emacs-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'install 'check
> + (lambda _
> + (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
> + "--eval" "(add-to-list 'load-path \"./tests\")"
> + "-l" "tests/elfeed-tests.el"
> + "-f" "ert-run-tests-batch-and-exit")))))))
> (home-page "https://github.com/skeeto/elfeed")
> (synopsis "Atom/RSS feed reader for Emacs")
> (description
Thanks for the patch! I checked out elfeed's makefile and it turns out
this patch can be made even simpler by just calling (zero? (system* "make"
"test")). Could you do that and sumbit the new patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
2017-04-02 17:02 ` Kei Kebreau
@ 2017-04-02 18:57 ` Arun Isaac
0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-02 18:57 UTC (permalink / raw)
To: 26342
Kei Kebreau writes:
> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
>> ---
>> gnu/packages/emacs.scm | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index cb2792f63..1091e562a 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
>> (base32
>> "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
>> (build-system emacs-build-system)
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-before 'install 'check
>> + (lambda _
>> + (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
>> + "--eval" "(add-to-list 'load-path \"./tests\")"
>> + "-l" "tests/elfeed-tests.el"
>> + "-f" "ert-run-tests-batch-and-exit")))))))
>> (home-page "https://github.com/skeeto/elfeed")
>> (synopsis "Atom/RSS feed reader for Emacs")
>> (description
>
> Thanks for the patch! I checked out elfeed's makefile and it turns out
> this patch can be made even simpler by just calling (zero? (system* "make"
> "test")). Could you do that and sumbit the new patch?
Ah, I missed the Makefile. I'll submit a new patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
2017-04-02 15:12 bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests Arun Isaac
2017-04-02 17:02 ` Kei Kebreau
@ 2017-04-02 19:20 ` Arun Isaac
2017-04-03 3:11 ` Kei Kebreau
2017-04-03 3:12 ` Kei Kebreau
1 sibling, 2 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-02 19:20 UTC (permalink / raw)
To: 26342
* gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
---
gnu/packages/emacs.scm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb2792f63..83c76113f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3100,6 +3100,12 @@ If you want to mark a folder manually as a project just create an empty
(base32
"145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
(build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'check
+ (lambda _
+ (zero? (system* "make" "test")))))))
(home-page "https://github.com/skeeto/elfeed")
(synopsis "Atom/RSS feed reader for Emacs")
(description
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
2017-04-02 19:20 ` Arun Isaac
@ 2017-04-03 3:11 ` Kei Kebreau
2017-04-03 3:12 ` Kei Kebreau
1 sibling, 0 replies; 6+ messages in thread
From: Kei Kebreau @ 2017-04-03 3:11 UTC (permalink / raw)
To: Arun Isaac; +Cc: 26342
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
> ---
> gnu/packages/emacs.scm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index cb2792f63..83c76113f 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3100,6 +3100,12 @@ If you want to mark a folder manually as a project just create an empty
> (base32
> "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
> (build-system emacs-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'install 'check
> + (lambda _
> + (zero? (system* "make" "test")))))))
> (home-page "https://github.com/skeeto/elfeed")
> (synopsis "Atom/RSS feed reader for Emacs")
> (description
Pushed to master as 568f977f9c4c2edd0f29b7627b315b716eda9c15. Thanks
again, Arun!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
2017-04-02 19:20 ` Arun Isaac
2017-04-03 3:11 ` Kei Kebreau
@ 2017-04-03 3:12 ` Kei Kebreau
1 sibling, 0 replies; 6+ messages in thread
From: Kei Kebreau @ 2017-04-03 3:12 UTC (permalink / raw)
To: 26342-done
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
The patch was applied to the master branch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-03 3:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-02 15:12 bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests Arun Isaac
2017-04-02 17:02 ` Kei Kebreau
2017-04-02 18:57 ` Arun Isaac
2017-04-02 19:20 ` Arun Isaac
2017-04-03 3:11 ` Kei Kebreau
2017-04-03 3:12 ` Kei Kebreau
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).