* bug#26839: [PATCH] system: Export 'read-boot-parameters'.
@ 2017-05-08 19:40 Alex Kost
2017-05-08 20:25 ` Danny Milosavljevic
0 siblings, 1 reply; 4+ messages in thread
From: Alex Kost @ 2017-05-08 19:40 UTC (permalink / raw)
To: 26839
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
line for 'read-boot-parameters'.
That procedure was used by Emacs-Guix code, and now
"M-x guix-system-generations" fails, so do you mind if
'read-boot-parameters' will be exported again?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-system-Export-read-boot-parameters.patch --]
[-- Type: text/x-diff, Size: 783 bytes --]
From 88051a2615352fd775badf0b79a7418424ff24c0 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Mon, 8 May 2017 22:03:37 +0300
Subject: [PATCH] system: Export 'read-boot-parameters'.
This partially reverts commit 9530e73b496fefe65dcb936825b6beda79f7fdf2.
* gnu/system.scm: Export 'read-boot-parameters' for backward compatibility.
---
gnu/system.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/system.scm b/gnu/system.scm
index baba0b5..3627813 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -108,6 +108,7 @@
boot-parameters-kernel
boot-parameters-kernel-arguments
boot-parameters-initrd
+ read-boot-parameters
read-boot-parameters-file
local-host-aliases
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#26839: [PATCH] system: Export 'read-boot-parameters'.
2017-05-08 19:40 bug#26839: [PATCH] system: Export 'read-boot-parameters' Alex Kost
@ 2017-05-08 20:25 ` Danny Milosavljevic
2017-05-09 19:11 ` Alex Kost
2017-05-13 9:20 ` Alex Kost
0 siblings, 2 replies; 4+ messages in thread
From: Danny Milosavljevic @ 2017-05-08 20:25 UTC (permalink / raw)
To: Alex Kost; +Cc: 26839
Hi Alex,
On Mon, 08 May 2017 22:40:59 +0300
Alex Kost <alezost@gmail.com> wrote:
> Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
> line for 'read-boot-parameters'.
>
> That procedure was used by Emacs-Guix code, and now
> "M-x guix-system-generations" fails, so do you mind if
> 'read-boot-parameters' will be exported again?
LGTM.
Be advised that these will not return all boot parameters that would actually boot a system successfully. That was also the case before the "--load" patch series. After the "--load" patch series, there's a new procedure "read-boot-parameters-file" that gives you all of them.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#26839: [PATCH] system: Export 'read-boot-parameters'.
2017-05-08 20:25 ` Danny Milosavljevic
@ 2017-05-09 19:11 ` Alex Kost
2017-05-13 9:20 ` Alex Kost
1 sibling, 0 replies; 4+ messages in thread
From: Alex Kost @ 2017-05-09 19:11 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 26839
Danny Milosavljevic (2017-05-08 22:25 +0200) wrote:
> Hi Alex,
>
> On Mon, 08 May 2017 22:40:59 +0300
> Alex Kost <alezost@gmail.com> wrote:
>
>> Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
>> line for 'read-boot-parameters'.
>>
>> That procedure was used by Emacs-Guix code, and now
>> "M-x guix-system-generations" fails, so do you mind if
>> 'read-boot-parameters' will be exported again?
>
> Be advised that these will not return all boot parameters that would
> actually boot a system successfully. That was also the case before the
> "--load" patch series. After the "--load" patch series, there's a new
> procedure "read-boot-parameters-file" that gives you all of them.
I know, thanks.
--
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#26839: [PATCH] system: Export 'read-boot-parameters'.
2017-05-08 20:25 ` Danny Milosavljevic
2017-05-09 19:11 ` Alex Kost
@ 2017-05-13 9:20 ` Alex Kost
1 sibling, 0 replies; 4+ messages in thread
From: Alex Kost @ 2017-05-13 9:20 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 26839-done
Danny Milosavljevic (2017-05-08 22:25 +0200) wrote:
> Hi Alex,
>
> On Mon, 08 May 2017 22:40:59 +0300
> Alex Kost <alezost@gmail.com> wrote:
>
>> Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
>> line for 'read-boot-parameters'.
>>
>> That procedure was used by Emacs-Guix code, and now
>> "M-x guix-system-generations" fails, so do you mind if
>> 'read-boot-parameters' will be exported again?
>
> LGTM.
Committed, thanks for looking at it!
--
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-13 9:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 19:40 bug#26839: [PATCH] system: Export 'read-boot-parameters' Alex Kost
2017-05-08 20:25 ` Danny Milosavljevic
2017-05-09 19:11 ` Alex Kost
2017-05-13 9:20 ` Alex Kost
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).