unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Meiyo Peng <meiyo@riseup.net>
Cc: 34845@debbugs.gnu.org, 34795-done@debbugs.gnu.org
Subject: bug#34795: [bug#34845] [PATCH 00/30] Update LXQt to 0.14.1.
Date: Thu, 14 Mar 2019 09:25:18 +0100	[thread overview]
Message-ID: <87h8c550cx.fsf@elephly.net> (raw)
In-Reply-To: <878sxiry2h.fsf@riseup.net>


Meiyo Peng <meiyo@riseup.net> writes:

>> I see that we already received a change set in #34795, which aims to
>> achieve the same goal.  Unfortunately, #34795 is just one big diff.
>
> Sorry.  I am not actively monitoring this mailing list, so I didn't
> notice that email.  I'm busy as hell and nearly wore out myself.

No worries, that’s why I mentioned it :)

>> Do you see anything in that diff that might be useful for this patch
>> series?
>
> I briefly checked that big diff and notice only one special hack not
> included in this patch series.
>
> He disabled the test for qemu in that patch:
>
> #+begin_src diff
>   diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
>   index 8d9d2335e..d935fd4e4 100644
>   --- a/gnu/packages/virtualization.scm
>   +++ b/gnu/packages/virtualization.scm
>   @@ -120,6 +120,7 @@
>        (arguments
>         '(;; Running tests in parallel can occasionally lead to failures, like:
>           ;; boot_sector_test: assertion failed (signature == SIGNATURE):
>   (0x00000000 == 0x0000dead)
>   +       #:tests? #f
>           #:parallel-tests? #f
>           #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
>                                   (string-append "--smbd="
> #+end_src
>
> This is probably a careless mistake.

Okay.  Thank you for checking!

> I have tested this patch series on my computer for over two weeks so I
> think it's probably safe to merge.

I looked through your patches and they look good to me.  Please push.

Thanks!

-- 
Ricardo

  reply	other threads:[~2019-03-14  8:31 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 12:56 [bug#34845] [PATCH 00/30] Update LXQt to 0.14.1 Meiyo Peng
2019-03-13 15:37 ` [bug#34845] [PATCH 01/30] gnu: menu-cache: Update to 1.1.0 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 02/30] gnu: libfm: Update to 1.3.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 03/30] gnu: lxqt-build-tools: Update to 0.6.0 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 04/30] gnu: libqtxdg: Update to 3.3.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 05/30] gnu: liblxqt: Update to 0.14.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 06/30] gnu: libsysstat: Update to 0.4.2 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 07/30] gnu: lxqt-about: Update to 0.14.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 08/30] gnu: lxqt-admin: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 09/30] gnu: lxqt-config: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 10/30] gnu: lxqt-globalkeys: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 11/30] gnu: lxqt-notificationd: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 12/30] gnu: lxqt-openssh-askpass: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 13/30] gnu: lxqt-panel: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 14/30] gnu: lxqt-policykit: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 15/30] gnu: lxqt-powermanagement: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 16/30] gnu: lxqt-qtplugin: Update to 0.14.0 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 17/30] gnu: lxqt-runner: Update to 0.14.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 18/30] gnu: lxqt-session: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 19/30] gnu: lxqt-sudo: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 20/30] gnu: lxqt-themes: Update to 0.14.0 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 21/30] gnu: libfm-qt: Update to 0.14.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 22/30] gnu: pcmanfm-qt: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 23/30] gnu: compton-conf: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 24/30] gnu: lximage-qt: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 25/30] gnu: obconf-qt: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 26/30] gnu: pavucontrol-qt: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 27/30] gnu: qps: Update to 1.10.20 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 28/30] gnu: qtermwidget: Update to 0.14.1 Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 29/30] gnu: qterminal: " Meiyo Peng
2019-03-13 15:37   ` [bug#34845] [PATCH 30/30] gnu: screengrab: Update to 1.101 Meiyo Peng
2019-03-13 16:22 ` [bug#34845] [PATCH 00/30] Update LXQt to 0.14.1 Ricardo Wurmus
2019-03-14  2:33   ` [bug#34795] " Meiyo Peng
2019-03-14  8:25     ` Ricardo Wurmus [this message]
2019-03-14 13:13       ` Meiyo Peng
2019-03-14 10:47 ` Danny Milosavljevic
2019-03-14 13:07   ` Meiyo Peng
2019-03-14 15:52     ` Danny Milosavljevic
2019-03-30 10:40       ` bug#34845: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8c550cx.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=34795-done@debbugs.gnu.org \
    --cc=34845@debbugs.gnu.org \
    --cc=meiyo@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).