From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:52852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4Llx-0006Ed-OY
	for guix-patches@gnu.org; Thu, 14 Mar 2019 04:31:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4Lgg-0003bl-Uk
	for guix-patches@gnu.org; Thu, 14 Mar 2019 04:26:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57495)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h4Lgg-0003bg-RQ
	for guix-patches@gnu.org; Thu, 14 Mar 2019 04:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4Lgg-0005Cs-Mz
	for guix-patches@gnu.org; Thu, 14 Mar 2019 04:26:02 -0400
Subject: bug#34795: [bug#34845] [PATCH 00/30] Update LXQt to 0.14.1.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.34795.D34795.155255195219983.done@debbugs.gnu.org>
References: <20190313125656.2822-1-meiyo@riseup.net>
	<87y35i4ucv.fsf@elephly.net> <878sxiry2h.fsf@riseup.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <878sxiry2h.fsf@riseup.net>
Date: Thu, 14 Mar 2019 09:25:18 +0100
Message-ID: <87h8c550cx.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Meiyo Peng <meiyo@riseup.net>
Cc: 34845@debbugs.gnu.org, 34795-done@debbugs.gnu.org


Meiyo Peng <meiyo@riseup.net> writes:

>> I see that we already received a change set in #34795, which aims to
>> achieve the same goal.  Unfortunately, #34795 is just one big diff.
>
> Sorry.  I am not actively monitoring this mailing list, so I didn't
> notice that email.  I'm busy as hell and nearly wore out myself.

No worries, that=E2=80=99s why I mentioned it :)

>> Do you see anything in that diff that might be useful for this patch
>> series?
>
> I briefly checked that big diff and notice only one special hack not
> included in this patch series.
>
> He disabled the test for qemu in that patch:
>
> #+begin_src diff
>   diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualizat=
ion.scm
>   index 8d9d2335e..d935fd4e4 100644
>   --- a/gnu/packages/virtualization.scm
>   +++ b/gnu/packages/virtualization.scm
>   @@ -120,6 +120,7 @@
>        (arguments
>         '(;; Running tests in parallel can occasionally lead to failures,=
 like:
>           ;; boot_sector_test: assertion failed (signature =3D=3D SIGNATU=
RE):
>   (0x00000000 =3D=3D 0x0000dead)
>   +       #:tests? #f
>           #:parallel-tests? #f
>           #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
>                                   (string-append "--smbd=3D"
> #+end_src
>
> This is probably a careless mistake.

Okay.  Thank you for checking!

> I have tested this patch series on my computer for over two weeks so I
> think it's probably safe to merge.

I looked through your patches and they look good to me.  Please push.

Thanks!

--=20
Ricardo