unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Tk <tk.code@protonmail.com>
Cc: 35810@debbugs.gnu.org
Subject: [bug#35810] [PATCH] Add RMassBank (r-massbank)
Date: Wed, 29 May 2019 00:16:44 +0200	[thread overview]
Message-ID: <87h89ekywj.fsf@elephly.net> (raw)
In-Reply-To: <874l5ju9mb.fsf@gnu.org>


Hi Todor,

>> The packages themselves have been generated using
>> `guix import cran -r --archive=bioconductor RMassBank` and minimally altered
>> to build successfully and not bother guix lint too much.
>
> Looks good to me.  Ricardo, WDYT?

Generally, the additions look fine, but with my nitpicking hat on I’d
like to make a few comments:

* Some of the packages have a list of licenses.  It would be good to add
  a comment above the license field to clarify what this list means.

* Some of descriptions begin with sentence fragments.  The importer is
  not smart enough to figure out the proper way to turn those fragments
  into full sentences.

* The synopses often contain capitalized words.

* I’d prefer the value of the home-page field to be on the same line as
  the field name.

* The module header contains references to unused modules, such as (guix
  git-download).

* I prefer for moving all CRAN packages to gnu/packages/cran.scm and all
  Bioconductor packages to gnu/packages/bioconductor.scm, because that
  makes future updates much easier.  That because CRAN packages rarely
  ever depend on Bioconductor packages, and keeping the number of
  mutually dependent modules down reduces the likelihood of dependency
  cycles.

  I haven’t always done it this way, but all recent additions are only
  to cran.scm and bioconductor.scm; I’m slowly moving CRAN packages from
  other locations to cran.scm for the above reasons.

* If you do move the package additions to existing modules, please make
  one commit per package addition.

(If this is all a bit too much to take in at first, I can also make the
changes on your behalf and keep your authorship.)

Thank you for your contributions!

--
Ricardo

  parent reply	other threads:[~2019-05-29 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 14:20 [bug#35810] [PATCH] Add RMassBank (r-massbank) Tk
2019-05-24 15:59 ` Ludovic Courtès
2019-05-25 14:00   ` Todor Kondić
2019-05-28 22:16   ` Ricardo Wurmus [this message]
2019-05-25 13:41 ` Todor Kondić
2019-07-07  7:06 ` [bug#35810] [PATCH] Add RMassBank (r-massbank) [CLOSING THIS ONE] Todor Kondić
2020-08-04 13:55 ` bug#35810: Closing [PATCH] Add RMassBank (r-massbank) Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h89ekywj.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=35810@debbugs.gnu.org \
    --cc=tk.code@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).