From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVzDO-0002KV-So for guix-patches@gnu.org; Wed, 29 May 2019 10:06:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVzDN-0006Zw-Ro for guix-patches@gnu.org; Wed, 29 May 2019 10:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVzDN-0006Ze-Ou for guix-patches@gnu.org; Wed, 29 May 2019 10:06:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVzDN-0003ro-I0 for guix-patches@gnu.org; Wed, 29 May 2019 10:06:01 -0400 Subject: [bug#35810] [PATCH] Add RMassBank (r-massbank) Resent-Message-ID: References: <0Wmcjgq-bpYQvMH_nhfAPRc8siXsADDFk0tfLvj-4onlp3m2aBbTJXEwrtdpbwWpgQnzn7-P8Hc6Gpq32B4rMmOq1GV8MkP75J2YJxSVMVs=@protonmail.com> <874l5ju9mb.fsf@gnu.org> From: Ricardo Wurmus In-reply-to: <874l5ju9mb.fsf@gnu.org> Date: Wed, 29 May 2019 00:16:44 +0200 Message-ID: <87h89ekywj.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tk Cc: 35810@debbugs.gnu.org Hi Todor, >> The packages themselves have been generated using >> `guix import cran -r --archive=3Dbioconductor RMassBank` and minimally a= ltered >> to build successfully and not bother guix lint too much. > > Looks good to me. Ricardo, WDYT? Generally, the additions look fine, but with my nitpicking hat on I=E2=80= =99d like to make a few comments: * Some of the packages have a list of licenses. It would be good to add a comment above the license field to clarify what this list means. * Some of descriptions begin with sentence fragments. The importer is not smart enough to figure out the proper way to turn those fragments into full sentences. * The synopses often contain capitalized words. * I=E2=80=99d prefer the value of the home-page field to be on the same lin= e as the field name. * The module header contains references to unused modules, such as (guix git-download). * I prefer for moving all CRAN packages to gnu/packages/cran.scm and all Bioconductor packages to gnu/packages/bioconductor.scm, because that makes future updates much easier. That because CRAN packages rarely ever depend on Bioconductor packages, and keeping the number of mutually dependent modules down reduces the likelihood of dependency cycles. I haven=E2=80=99t always done it this way, but all recent additions are o= nly to cran.scm and bioconductor.scm; I=E2=80=99m slowly moving CRAN packages= from other locations to cran.scm for the above reasons. * If you do move the package additions to existing modules, please make one commit per package addition. (If this is all a bit too much to take in at first, I can also make the changes on your behalf and keep your authorship.) Thank you for your contributions! -- Ricardo