unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file.
@ 2020-04-29  7:37 Brice Waegeneire
  2020-04-29  7:50 ` [bug#40953] #40953 fixes #40945 Brice Waegeneire
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Brice Waegeneire @ 2020-04-29  7:37 UTC (permalink / raw)
  To: 40953

* gnu/services/admin.scm (%default-rotations): Add option 'storefile'.
---
 gnu/services/admin.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/services/admin.scm b/gnu/services/admin.scm
index df3cb01646..89fa73920d 100644
--- a/gnu/services/admin.scm
+++ b/gnu/services/admin.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2016, 2017, 2018, 2019 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,8 +72,11 @@
   (list (log-rotation                             ;syslog files
          (files %rotated-files)
 
+         (options '(;; Run post-rotate once per rotation
+                    "sharedscripts"
+                    ;; Append .gz to rotated files
+                    "storefile @FILENAME.@COMP_EXT"))
          ;; Restart syslogd after rotation.
-         (options '("sharedscripts"))
          (post-rotate #~(let ((pid (call-with-input-file "/var/run/syslog.pid"
                                      read)))
                           (kill pid SIGHUP))))
-- 
2.26.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#40953] #40953 fixes #40945
  2020-04-29  7:37 [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Brice Waegeneire
@ 2020-04-29  7:50 ` Brice Waegeneire
  2020-05-01 22:01 ` [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Ludovic Courtès
  2020-05-06  9:17 ` bug#40953: (no subject) Brice Waegeneire
  2 siblings, 0 replies; 4+ messages in thread
From: Brice Waegeneire @ 2020-04-29  7:50 UTC (permalink / raw)
  To: 40953

This patch should fix https://issues.guix.info/issue/40945




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file.
  2020-04-29  7:37 [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Brice Waegeneire
  2020-04-29  7:50 ` [bug#40953] #40953 fixes #40945 Brice Waegeneire
@ 2020-05-01 22:01 ` Ludovic Courtès
  2020-05-06  9:17 ` bug#40953: (no subject) Brice Waegeneire
  2 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-05-01 22:01 UTC (permalink / raw)
  To: Brice Waegeneire; +Cc: 40953

Hi,

Brice Waegeneire <brice@waegenei.re> skribis:

> * gnu/services/admin.scm (%default-rotations): Add option 'storefile'.

Please add “Fixes <https://bugs.gnu.org/...>.”

LGTM!  That problem had always annoyed me.

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#40953: (no subject)
  2020-04-29  7:37 [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Brice Waegeneire
  2020-04-29  7:50 ` [bug#40953] #40953 fixes #40945 Brice Waegeneire
  2020-05-01 22:01 ` [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Ludovic Courtès
@ 2020-05-06  9:17 ` Brice Waegeneire
  2 siblings, 0 replies; 4+ messages in thread
From: Brice Waegeneire @ 2020-05-06  9:17 UTC (permalink / raw)
  To: 40953-done

Pushed as ab034adfe86333fccd6afe476806f169e2074d69.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-06  9:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29  7:37 [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Brice Waegeneire
2020-04-29  7:50 ` [bug#40953] #40953 fixes #40945 Brice Waegeneire
2020-05-01 22:01 ` [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated file Ludovic Courtès
2020-05-06  9:17 ` bug#40953: (no subject) Brice Waegeneire

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).