From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 40993@debbugs.gnu.org
Subject: [bug#40993] cuirass: Add build products download support.
Date: Wed, 10 Jun 2020 17:44:29 +0200 [thread overview]
Message-ID: <87h7vjlyci.fsf@gmail.com> (raw)
In-Reply-To: <875zc7ki9g.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 03 Jun 2020 22:26:51 +0200")
Hola!
> For the record, in Hydra, build products would be found if there’s a
> special ‘nix-support/hydra-build-products’ file in the output. The
> advantage is that it’s more flexible, but the downside is that you’d
> have to adjust your derivations specifically for that.
Yes, I first hesitated to replicate this mechanism but finally opted for
the implemented one. I didn't like so much the idea of adding and extra,
CI-specific file, to the output of some jobs.
> Use ‘for-each’ if it’s for effects, as seems to be the case.
Oh you keep repeating that to me, and I keep doing the same mistake!
> Regarding #:sha256-hash: there’s a somewhat standard format to represent
> hashes and their algorithms as strings, but I forgot the name. Like,
> you’d write “sha256-” followed by a base64 string, something like that.
>
> Perhaps it’d be wiser to use it rather than hard-code sha256?
Yes sure, I changed the database field to "checksum" so that we can use
the string representation you're talking about.
> Also, we don’t really have tests for the web UI, I don’t know how much
> work it’d be to add tests.
If a more web-aware hacker could propose something, it would be great
indeed :)
> Apart from that, I have little to say, other than the fact that it’s
> really cool. :-)
Thanks for reviewing! I just pushed those two commits and updated the
Cuirass package. Now I'll see with Marius or Ricardo how to update
Berlin, I guess.
Thanks,
Mathieu
prev parent reply other threads:[~2020-06-10 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 8:54 [bug#40993] cuirass: Add build products download support Mathieu Othacehe
2020-05-01 10:09 ` Danny Milosavljevic
2020-05-01 13:35 ` Mathieu Othacehe
2020-05-01 21:17 ` Ludovic Courtès
2020-06-03 11:54 ` Mathieu Othacehe
2020-06-03 20:14 ` Ludovic Courtès
2020-05-01 21:11 ` Ludovic Courtès
2020-06-03 20:26 ` Ludovic Courtès
2020-06-10 15:44 ` Mathieu Othacehe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7vjlyci.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=40993@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).