From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: Danny Milosavljevic <dannym@scratchpost.org>, 40993@debbugs.gnu.org
Subject: [bug#40993] cuirass: Add build products download support.
Date: Fri, 01 May 2020 23:17:09 +0200 [thread overview]
Message-ID: <871ro3e4oa.fsf@gnu.org> (raw)
In-Reply-To: <874ksz4w21.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 01 May 2020 15:35:50 +0200")
Hello!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> With the (very) hacky patch attached, I fool sanitize-response, by
> sending the file name as a bytevector. This allows me to save gigabytes
> of RAM when downloading disk images.
Yay! This is similar to what ‘guix publish’ does. :-)
> From 0c5e91c170639d50d1cc339fa0b0e68ea4fba68c Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Fri, 1 May 2020 15:03:12 +0200
> Subject: [PATCH] cuirass: Use sendfiles instead of raw copies.
>
> * src/cuirass/http.scm (respond-file): Send the file name as an UTF8
> bytevector, instead of the raw file content,
> (respond-gzipped-file): ditto. Also set 'content-disposition header.
> * src/web/server/fiberized.scm (client-loop): Check if 'content-disposition is
> set. If it's the case, assume that the bytevector is the file name, and use
> sendfiles to send it. Otherwise, keep the existing behaviour and send directly
> the received bytevector.
> +(define extend-response (@@ (web server) extend-response))
@@ is evil and it’s not guaranteed to work with Guile 3: the procedure
might be inlined.
But you can use these ‘guix publish’ helper procedures, which rely on
(srfi srfi-9 gnu):
(define (strip-headers response)
"Return RESPONSE's headers minus 'Content-Length' and our internal headers."
(fold alist-delete
(response-headers response)
'(content-length x-raw-file x-nar-compression)))
(define (with-content-length response length)
"Return RESPONSE with a 'content-length' header set to LENGTH."
(set-field response (response-headers)
(alist-cons 'content-length length
(strip-headers response))))
> + (call-with-input-file file
> + (lambda (port)
> + (write-response
> + (extend-response response 'content-length
> + file-size)
> + client)
> + (sendfile client port file-size))))
I didn’t look at the other patches, but note that ‘sendfile’ blocks.
Since Cuirass is fiberized, you shouldn’t block a fiber.
‘guix publish’ doesn’t use Fibers but it shouldn’t block either while
sending a nar, so what it does is spawn a new thread for the ‘sendfile’
call.
HTH!
Ludo’.
next prev parent reply other threads:[~2020-05-01 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 8:54 [bug#40993] cuirass: Add build products download support Mathieu Othacehe
2020-05-01 10:09 ` Danny Milosavljevic
2020-05-01 13:35 ` Mathieu Othacehe
2020-05-01 21:17 ` Ludovic Courtès [this message]
2020-06-03 11:54 ` Mathieu Othacehe
2020-06-03 20:14 ` Ludovic Courtès
2020-05-01 21:11 ` Ludovic Courtès
2020-06-03 20:26 ` Ludovic Courtès
2020-06-10 15:44 ` Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ro3e4oa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40993@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).