* [bug#42024] [PATCH] nix: Tweak .gitignore files.
@ 2020-06-23 17:27 Christopher Baines
2020-06-23 21:14 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2020-06-23 17:27 UTC (permalink / raw)
To: 42024
Remove .gitignore entries where they match source files that are tracked in
Git. This is relevant to me at least, as some code searching tools use
.gitignore files and will ignore matched files.
* nix/boost/.gitignore: Delete this file.
* nix/libutils/.gitignore: Delete this file.
* nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
(/schema.sql.hh): New entry.
---
nix/boost/.gitignore | 3 ---
nix/libstore/.gitignore | 3 +--
nix/libutil/.gitignore | 2 --
3 files changed, 1 insertion(+), 7 deletions(-)
delete mode 100644 nix/boost/.gitignore
delete mode 100644 nix/libutil/.gitignore
diff --git a/nix/boost/.gitignore b/nix/boost/.gitignore
deleted file mode 100644
index 1f188e3b65..0000000000
--- a/nix/boost/.gitignore
+++ /dev/null
@@ -1,3 +0,0 @@
-*.hpp
-*.cpp
-*.cc
diff --git a/nix/libstore/.gitignore b/nix/libstore/.gitignore
index 512a0d022f..805301d6d7 100644
--- a/nix/libstore/.gitignore
+++ b/nix/libstore/.gitignore
@@ -1,3 +1,2 @@
-*.cc
-*.hh
/schema.sql
+/schema.sql.hh
diff --git a/nix/libutil/.gitignore b/nix/libutil/.gitignore
deleted file mode 100644
index e539428b1b..0000000000
--- a/nix/libutil/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@
-*.cc
-*.hh
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#42024] [PATCH] nix: Tweak .gitignore files.
2020-06-23 17:27 [bug#42024] [PATCH] nix: Tweak .gitignore files Christopher Baines
@ 2020-06-23 21:14 ` Ludovic Courtès
2020-06-24 19:00 ` bug#42024: " Christopher Baines
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2020-06-23 21:14 UTC (permalink / raw)
To: Christopher Baines; +Cc: 42024
Christopher Baines <mail@cbaines.net> skribis:
> Remove .gitignore entries where they match source files that are tracked in
> Git. This is relevant to me at least, as some code searching tools use
> .gitignore files and will ignore matched files.
>
> * nix/boost/.gitignore: Delete this file.
> * nix/libutils/.gitignore: Delete this file.
> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
> (/schema.sql.hh): New entry.
LGTM! I don’t know what the rationale was.
BTW, no need to bother with ChangeLog entries for this.
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#42024: [PATCH] nix: Tweak .gitignore files.
2020-06-23 21:14 ` Ludovic Courtès
@ 2020-06-24 19:00 ` Christopher Baines
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2020-06-24 19:00 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 42024-done
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Remove .gitignore entries where they match source files that are tracked in
>> Git. This is relevant to me at least, as some code searching tools use
>> .gitignore files and will ignore matched files.
>>
>> * nix/boost/.gitignore: Delete this file.
>> * nix/libutils/.gitignore: Delete this file.
>> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
>> (/schema.sql.hh): New entry.
>
> LGTM! I don’t know what the rationale was.
>
> BTW, no need to bother with ChangeLog entries for this.
Great, I've removed the ChangeLog entries and pushed this as
cd43b55da7ab51c996a7a3449c78f2a493616106.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-24 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 17:27 [bug#42024] [PATCH] nix: Tweak .gitignore files Christopher Baines
2020-06-23 21:14 ` Ludovic Courtès
2020-06-24 19:00 ` bug#42024: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).