From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 43743@debbugs.gnu.org
Cc: tomasortin@mailbox.org
Subject: [bug#43743] [PATCH] Add package emacs-windsize
Date: Sun, 04 Oct 2020 11:40:43 +0200 [thread overview]
Message-ID: <87h7rawcpw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <89b55036-1e90-d92b-c3b0-8abf09b4af0c@mailbox.org> ("Tomás Ortín Fernández via Guix-patches via"'s message of "Thu, 1 Oct 2020 14:23:11 +0200")
Hello,
Tomás Ortín Fernández via Guix-patches via <guix-patches@gnu.org>
writes:
> Add windsize.el Emacs package
Thank you. Somme comments follow.
> + (version "20181029")
This is not the official release number. This should be "0.1", with an
appropriate revision number since you're not using the release tag. Also
there should be a comment explaining why you're not using that release
tag (almost 10 years old here).
See, for example, emacs-dhall-mode package.
> + (source (origin
Please move origin below source.
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/grammati/windsize")
> + (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa")))
The commit should be bound to a variable at the top of the package
definition.
> + (sha256
> + (base32
> + "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))
Nitpick: Please move the hash on the same line as base32
> + (build-system emacs-build-system)
> + (home-page "https://github.com/grammati/windsize")
> + (synopsis "Easy resizing of emacs windows")
-> Emacs windows
> + (description "Move the borders of the active window with the arrow
> +keys (C-S-<dir> by default). Always prefers to move the right or
> +bottom border when possible, and falls back to moving the left or top
> +border otherwise.")
I suggest to use non-imperative wording, e.g., This package allows
moving... It always prefers…
I also suggest to remove the reference to (C-S-<dir> ...) since it
belongs to the documentation of the package, not to its description.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-04 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 12:23 [bug#43743] [PATCH] Add package emacs-windsize Tomás Ortín Fernández via Guix-patches via
2020-10-04 9:40 ` Nicolas Goaziou [this message]
2020-10-04 14:58 ` Tomás Ortín Fernández
2020-10-07 19:54 ` bug#43743: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7rawcpw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43743@debbugs.gnu.org \
--cc=tomasortin@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).