From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ICpBC7aYeV+ZIwAA0tVLHw (envelope-from ) for ; Sun, 04 Oct 2020 09:41:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eGo+B7aYeV/2PgAA1q6Kng (envelope-from ) for ; Sun, 04 Oct 2020 09:41:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF9949401BE for ; Sun, 4 Oct 2020 09:41:09 +0000 (UTC) Received: from localhost ([::1]:44956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP0Vw-0001Qw-H3 for larch@yhetil.org; Sun, 04 Oct 2020 05:41:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP0Vq-0001Qn-5s for guix-patches@gnu.org; Sun, 04 Oct 2020 05:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kP0Vp-00033Z-T8 for guix-patches@gnu.org; Sun, 04 Oct 2020 05:41:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kP0Vp-0004I6-Rh for guix-patches@gnu.org; Sun, 04 Oct 2020 05:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43743] [PATCH] Add package emacs-windsize Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Oct 2020 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43743 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43743@debbugs.gnu.org Cc: tomasortin@mailbox.org X-Debbugs-Original-To: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= via Guix-patches via X-Debbugs-Original-Cc: 43743@debbugs.gnu.org, =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= Received: via spool by submit@debbugs.gnu.org id=B.160180446016475 (code B ref -1); Sun, 04 Oct 2020 09:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Oct 2020 09:41:00 +0000 Received: from localhost ([127.0.0.1]:44972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP0Vo-0004Hf-Ib for submit@debbugs.gnu.org; Sun, 04 Oct 2020 05:41:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:33720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP0Vn-0004HY-GM for submit@debbugs.gnu.org; Sun, 04 Oct 2020 05:40:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP0Vn-0001QO-9D for guix-patches@gnu.org; Sun, 04 Oct 2020 05:40:59 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:44905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP0Vl-0002yd-7f for guix-patches@gnu.org; Sun, 04 Oct 2020 05:40:58 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id DD3DA200003; Sun, 4 Oct 2020 09:40:53 +0000 (UTC) From: Nicolas Goaziou References: <89b55036-1e90-d92b-c3b0-8abf09b4af0c@mailbox.org> Date: Sun, 04 Oct 2020 11:40:43 +0200 In-Reply-To: <89b55036-1e90-d92b-c3b0-8abf09b4af0c@mailbox.org> ("=?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= via Guix-patches via"'s message of "Thu, 1 Oct 2020 14:23:11 +0200") Message-ID: <87h7rawcpw.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/04 05:40:54 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.6 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: YygR05K5gaem Hello, Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez via Guix-patches via writes: > Add windsize.el Emacs package Thank you. Somme comments follow. > + (version "20181029") This is not the official release number. This should be "0.1", with an appropriate revision number since you're not using the release tag. Also there should be a comment explaining why you're not using that release tag (almost 10 years old here). See, for example, emacs-dhall-mode package. > + (source (origin Please move origin below source. > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/grammati/windsize") > + (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa"))) The commit should be bound to a variable at the top of the package definition. > + (sha256 > + (base32 > + "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))= )) Nitpick: Please move the hash on the same line as base32 > + (build-system emacs-build-system) > + (home-page "https://github.com/grammati/windsize") > + (synopsis "Easy resizing of emacs windows") -> Emacs windows > + (description "Move the borders of the active window with the arrow > +keys (C-S- by default). Always prefers to move the right or > +bottom border when possible, and falls back to moving the left or top > +border otherwise.") I suggest to use non-imperative wording, e.g., This package allows moving... It always prefers=E2=80=A6 I also suggest to remove the reference to (C-S- ...) since it belongs to the documentation of the package, not to its description. Could you send an updated patch? Regards, --=20 Nicolas Goaziou