From: Mathieu Othacehe <othacehe@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 48320@debbugs.gnu.org
Subject: [bug#48320] [PATCH v2] lint: Verify if #:tests? is respected in the 'check' phase.
Date: Tue, 29 Jun 2021 12:34:48 +0200 [thread overview]
Message-ID: <87h7hhvu0n.fsf@gnu.org> (raw)
In-Reply-To: <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> (Maxime Devos's message of "Mon, 28 Jun 2021 23:15:42 +0200")
Hello Maxime,
Thanks for the new revision.
> +@deffn {Procedure} gexp->approximate-sexp @var{gexp}
> +Sometimes, it may be useful to convert a G-exp into a S-exp.
> +For example, some linters (@pxref{Invoking guix lint})
You can write longer sentences here, up to 78 columns. If you are using
Emacs, fill-paragraph does the right thing.
> + (define (sexp-uses-tests?? sexp)
> + "Test if SEXP contains the symbol 'tests?'."
> + (sexp-contains-atom? sexp 'tests?))
> + (define (sexp-contains-atom? sexp atom)
> + "Test if SEXP contains ATOM."
> + (if (pair? sexp)
> + (or (sexp-contains-atom? (car sexp) atom)
> + (sexp-contains-atom? (cdr sexp) atom))
> + (eq? sexp atom)))
It would make more sense to define "sexp-uses-tests??" later as it uses
"sexp-contains-atom" that is defined afterwards.
> + (or (check-phases-delta head)
> + (check-phases-deltas tail)))
I think it should be "append" instead of "or". Otherwise, it fails to
detect package which 'replace is not the first phase, see mkvtoolnix for
instance.
Otherwise looks fine :)
Thanks,
Mathieu
next prev parent reply other threads:[~2021-06-29 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 18:02 [bug#48320] [PATCH] lint: Verify if #:tests? is respected in the 'check' phase Maxime Devos
2021-06-18 12:15 ` Mathieu Othacehe
2021-06-18 15:34 ` Maxime Devos
2021-06-28 21:15 ` [bug#48320] [PATCH v2] " Maxime Devos
2021-06-29 10:34 ` Mathieu Othacehe [this message]
2021-06-30 10:31 ` [bug#48320] [PATCH v3] " Maxime Devos
2021-06-30 11:55 ` bug#48320: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7hhvu0n.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=48320@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).