From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CFGuJWb32mCN1AAAgWs5BA (envelope-from ) for ; Tue, 29 Jun 2021 12:35:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +NVWIWb32mDVewAAbx9fmQ (envelope-from ) for ; Tue, 29 Jun 2021 10:35:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CE6C1D44C for ; Tue, 29 Jun 2021 12:35:18 +0200 (CEST) Received: from localhost ([::1]:45144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyB5J-0003UG-3L for larch@yhetil.org; Tue, 29 Jun 2021 06:35:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyB54-0003U6-L3 for guix-patches@gnu.org; Tue, 29 Jun 2021 06:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyB54-0004q5-Dv for guix-patches@gnu.org; Tue, 29 Jun 2021 06:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyB54-0005A0-7u for guix-patches@gnu.org; Tue, 29 Jun 2021 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48320] [PATCH v2] lint: Verify if #:tests? is respected in the 'check' phase. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Jun 2021 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 48320@debbugs.gnu.org Received: via spool by 48320-submit@debbugs.gnu.org id=B48320.162496289919823 (code B ref 48320); Tue, 29 Jun 2021 10:35:02 +0000 Received: (at 48320) by debbugs.gnu.org; 29 Jun 2021 10:34:59 +0000 Received: from localhost ([127.0.0.1]:53657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyB51-00059f-4O for submit@debbugs.gnu.org; Tue, 29 Jun 2021 06:34:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyB4y-00059S-QO for 48320@debbugs.gnu.org; Tue, 29 Jun 2021 06:34:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50200) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyB4s-0004jg-Vk; Tue, 29 Jun 2021 06:34:51 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=59006 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyB4r-0001XH-Ax; Tue, 29 Jun 2021 06:34:50 -0400 From: Mathieu Othacehe References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> Date: Tue, 29 Jun 2021 12:34:48 +0200 In-Reply-To: <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> (Maxime Devos's message of "Mon, 28 Jun 2021 23:15:42 +0200") Message-ID: <87h7hhvu0n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624962918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=dfqkDC/2NVIyBza/M+TQtlakZr+A+ATeHR6JfJle9lg=; b=gOV8Yc97SMGwK+mgY/XfpdX+kbfzZwxZfMyabbud0Um0rb/9mybhjku7XV11wg2bFdsxUq znFXSk9FjiEq71/4JvFqXUenlIKH5wAAOeOGwPFkcLeZDiL8HrlLQhAaXnb20NWzonQzuJ UM/+kx4TTKhbbY4DRoWHdJeN/u/qErfqzSHYXpjQF96k6G8Xh8RnxBCnRRhbBq7I/zyofR 3smCeicLC6Rb+vEldxSSIHArss/5zHprHpLQkMc2BteA2BrNcPWrZFDrIe1bcu7JUcyuIA 3Vg4ZXmQ6f/5m2gfXwnelSWmroqkK4wAFgMN5H4iRshXKxbb8aXedjN3BGwjzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624962918; a=rsa-sha256; cv=none; b=B1sCjAcvx506KtrLmlsv0xL+jsDdpBIZpAOqziiIAKiZOtlW8g1YN0GfEP4Aqkhu7R2koQ MlFRbDGxbB0dNjDVh4csfdff+6jZIMqnSbiR26oIXj5HEHG/VgwH3kXDMP1luXlENsQ0k4 Y7OSkWT7wP1SPqX1TPJoFsV3PHSRSAn5HbkN6wtKcfs5UYQ6GF/t6OP6+/AZMV6WK5a4m5 6o3vrvEzPy6Xm3T2hGD4oILX4TuVlHCprRaEABs5gUylQY6AMbXp7Twiqa6Z6o/iMufBga QWEgscWu1jtZ82iu1Wc+7yKM2maLq6K/syrUTfjoDYyEW1JoG7yE9NXFm6MllQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2CE6C1D44C X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: +7rp2X2bzq82 Hello Maxime, Thanks for the new revision. > +@deffn {Procedure} gexp->approximate-sexp @var{gexp} > +Sometimes, it may be useful to convert a G-exp into a S-exp. > +For example, some linters (@pxref{Invoking guix lint}) You can write longer sentences here, up to 78 columns. If you are using Emacs, fill-paragraph does the right thing. > + (define (sexp-uses-tests?? sexp) > + "Test if SEXP contains the symbol 'tests?'." > + (sexp-contains-atom? sexp 'tests?)) > + (define (sexp-contains-atom? sexp atom) > + "Test if SEXP contains ATOM." > + (if (pair? sexp) > + (or (sexp-contains-atom? (car sexp) atom) > + (sexp-contains-atom? (cdr sexp) atom)) > + (eq? sexp atom))) It would make more sense to define "sexp-uses-tests??" later as it uses "sexp-contains-atom" that is defined afterwards. > + (or (check-phases-delta head) > + (check-phases-deltas tail))) I think it should be "append" instead of "or". Otherwise, it fails to detect package which 'replace is not the first phase, see mkvtoolnix for instance. Otherwise looks fine :) Thanks, Mathieu