unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: dan <i@dan.games>, 59386@debbugs.gnu.org
Subject: [bug#59386] [PATCH staging 00/11] Update vulkan-sdk packages to sdk-1.3.231.1.
Date: Sun, 20 Nov 2022 09:06:04 +0100	[thread overview]
Message-ID: <87h6yu124z.fsf@gnu.org> (raw)
In-Reply-To: <20221119145607.18471-1-i@dan.games>

[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]

dan <i@dan.games> skriver:

> Hello Guix,
>
> This patch series update several vulkan-sdk packages to the latest sdk release
> version sdk-1.3.231.1.  With each vulkan-sdk release, there is a config.json
> file detailing all the version of the included packages[1].  To make sure
> these packages are compatible, we introduced a variable %vulkan-sdk-version to
> replace the [version] field of each vulkan-sdk packages.  One exception is
> shaderc, which is developed by Google, and it uses its own versioning scheme.

Thanks for this explanation.

> For the versioning scheme of the vulkan-sdk, I intentionally included the
> 'sdk-' prefix into the version string since some of the packages used to have
> their own versioning semantic and later changed to this kind of 'unified' sdk
> versioning semantic, as Kaelyn explained in #58617[2].

Makes sense.  I'm partial to removing "sdk-" from %vulkan-sdk-version
and instead use (commit (string-append "sdk-" version)) in sources, but
no strong opinion.

(feedback from other contributors wanted!)

> Huge shout out to Kaelyn, who composed #57297 and #58617, trying to bring the
> latest version of vulkan-sdk to guix.  I see recently #57297 got merged into
> staging, and it would be a good chance to update these vulkan packages to
> match the latest version.

Great, thank you!  I've applied the patches up to and including 'volk'
with minor tweaks and will comment separately on the remaining patch +
changes done.

> [1]: https://sdk.lunarg.com/sdk/download/1.3.231.1/linux/config.json
> [2]: https://issues.guix.gnu.org/58617
>
> dan (11):
>   gnu: spirv-headers: Replace version with %vulkan-sdk-version.
>   gnu: spirv-tools: Replace version with %vulkan-sdk-version.
>   gnu: glslang: Update to sdk-1.3.231.1.
>   gnu: spirv-cross: Update to sdk-1.3.231.1.
>   gnu: shaderc: Update to 2022.3.
>   gnu: vulkan-headers: Update to sdk-1.3.231.1.
>   gnu: vulkan-loader: Update to sdk-1.3.231.1.
>   gnu: vulkan-tools: Update to sdk-1.3.231.1.
>   gnu: vulkan-validationlayers: Update to sdk-1.3.231.1.
>   gnu: Add volk.
>   gnu: Add vulkan-memory-allocator.
>
>  gnu/packages/vulkan.scm | 132 +++++++++++++++++++++++++++++-----------
>  1 file changed, 98 insertions(+), 34 deletions(-)
>
>
> base-commit: f8e1c9c003999cf20db2d7e5c1aa2c64c787056d
> -- 
> 2.38.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  parent reply	other threads:[~2022-11-20  8:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 14:56 [bug#59386] [PATCH staging 00/11] Update vulkan-sdk packages to sdk-1.3.231.1 dan
2022-11-19 15:02 ` [bug#59386] [PATCH 01/11] gnu: spirv-headers: Replace version with %vulkan-sdk-version dan
2022-11-19 15:02   ` [bug#59386] [PATCH 02/11] gnu: spirv-tools: " dan
2022-11-19 15:02   ` [bug#59386] [PATCH 03/11] gnu: glslang: Update to sdk-1.3.231.1 dan
2022-11-19 15:02   ` [bug#59386] [PATCH 04/11] gnu: spirv-cross: " dan
2022-11-19 15:02   ` [bug#59386] [PATCH 05/11] gnu: shaderc: Update to 2022.3 dan
2022-11-19 15:02   ` [bug#59386] [PATCH 06/11] gnu: vulkan-headers: Update to sdk-1.3.231.1 dan
2022-11-19 15:02   ` [bug#59386] [PATCH 07/11] gnu: vulkan-loader: " dan
2022-11-19 15:02   ` [bug#59386] [PATCH 08/11] gnu: vulkan-tools: " dan
2022-11-19 15:02   ` [bug#59386] [PATCH 09/11] gnu: vulkan-validationlayers: " dan
2022-11-20  8:11     ` Marius Bakke
2022-11-19 15:02   ` [bug#59386] [PATCH 10/11] gnu: Add volk dan
2022-11-20  8:14     ` Marius Bakke
2022-11-19 15:02   ` [bug#59386] [PATCH 11/11] gnu: Add vulkan-memory-allocator dan
2022-11-20  8:24     ` Marius Bakke
2022-11-20  8:06 ` Marius Bakke [this message]
2022-11-20 13:49 ` [bug#59386] [PATCH] " dan
2022-11-20 16:25   ` bug#59386: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6yu124z.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=59386@debbugs.gnu.org \
    --cc=i@dan.games \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).