From: Marius Bakke <marius@gnu.org>
To: dan <i@dan.games>, 59386@debbugs.gnu.org
Subject: [bug#59386] [PATCH 11/11] gnu: Add vulkan-memory-allocator.
Date: Sun, 20 Nov 2022 09:24:40 +0100 [thread overview]
Message-ID: <878rk6119z.fsf@gnu.org> (raw)
In-Reply-To: <20221119150248.19150-11-i@dan.games>
[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]
dan <i@dan.games> skriver:
> * gnu/packages/vulkan.scm (vulkan-memory-allocator): New variable.
[...]
> +(define-public vulkan-memory-allocator
> + (package
> + (name "vulkan-memory-allocator")
> + (version "3.0.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator"
> + "/archive/refs/tags/v" version ".tar.gz"))
The GitHub "/archive" URLs are not stable: the tarballs are generated on
demand and cached; when the cache expires they get regenerated with
different time stamps.
Use git-fetch instead.
> + (build-system cmake-build-system)
> + (arguments
> + ; no test
> + `(#:tests? #f))
> + (inputs
> + (list vulkan-loader
> + vulkan-headers))
Please run './pre-inst-env guix style vulkan-memory-allocator'. :-)
> + (synopsis "Easy to integrate Vulkan memory allocation library")
Just 'Vulkan memory allocation library' is sufficient.
> + (description "Easy to integrate Vulkan memory allocation library.")
Can you turn this into a full sentence, i.e. "vulkan-memory-allocator is
an easy to integrate ...", ideally with some information about what that
means for potential users?
Can you send an updated patch?
TIA!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2022-11-20 8:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 14:56 [bug#59386] [PATCH staging 00/11] Update vulkan-sdk packages to sdk-1.3.231.1 dan
2022-11-19 15:02 ` [bug#59386] [PATCH 01/11] gnu: spirv-headers: Replace version with %vulkan-sdk-version dan
2022-11-19 15:02 ` [bug#59386] [PATCH 02/11] gnu: spirv-tools: " dan
2022-11-19 15:02 ` [bug#59386] [PATCH 03/11] gnu: glslang: Update to sdk-1.3.231.1 dan
2022-11-19 15:02 ` [bug#59386] [PATCH 04/11] gnu: spirv-cross: " dan
2022-11-19 15:02 ` [bug#59386] [PATCH 05/11] gnu: shaderc: Update to 2022.3 dan
2022-11-19 15:02 ` [bug#59386] [PATCH 06/11] gnu: vulkan-headers: Update to sdk-1.3.231.1 dan
2022-11-19 15:02 ` [bug#59386] [PATCH 07/11] gnu: vulkan-loader: " dan
2022-11-19 15:02 ` [bug#59386] [PATCH 08/11] gnu: vulkan-tools: " dan
2022-11-19 15:02 ` [bug#59386] [PATCH 09/11] gnu: vulkan-validationlayers: " dan
2022-11-20 8:11 ` Marius Bakke
2022-11-19 15:02 ` [bug#59386] [PATCH 10/11] gnu: Add volk dan
2022-11-20 8:14 ` Marius Bakke
2022-11-19 15:02 ` [bug#59386] [PATCH 11/11] gnu: Add vulkan-memory-allocator dan
2022-11-20 8:24 ` Marius Bakke [this message]
2022-11-20 8:06 ` [bug#59386] [PATCH staging 00/11] Update vulkan-sdk packages to sdk-1.3.231.1 Marius Bakke
2022-11-20 13:49 ` [bug#59386] [PATCH] gnu: Add vulkan-memory-allocator dan
2022-11-20 16:25 ` bug#59386: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rk6119z.fsf@gnu.org \
--to=marius@gnu.org \
--cc=59386@debbugs.gnu.org \
--cc=i@dan.games \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).