From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: sourcepluck@posteo.net
Cc: 62503-done@debbugs.gnu.org
Subject: bug#62503: emacs-beframe
Date: Thu, 30 Mar 2023 22:50:35 +0200 [thread overview]
Message-ID: <87h6u2klpg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <a4231f1f76eb2fc09de3bc9a64add78b@posteo.net> (sourcepluck@posteo.net's message of "Tue, 28 Mar 2023 13:44:26 +0000")
Hello,
sourcepluck@posteo.net writes:
> Jamie Cullen here. This is my first ever patch, first ever commit,
> first ever packaged package, first ever time doing anything mildly
> useful with Git, etc etc. Excitement is tantamount here.
This sure is a good first patch. Since I had only nitpicks to write,
I applied it directly. Thank you!
> Please don't hesitate to tell me about even the smallest modification
> on my side, and any length of an explanation here via mail.
I wrote below what small changes I made to your package definition.
> +(define-public emacs-beframe
> + (package
> + (name "emacs-beframe")
> + (version "0.2.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~protesilaos/beframe")
> + (commit "edfab6eefe4ac35cd8d1ed87fc7f670496d25e40")))
We don't usually insert commit hashes here, but rather bind hash to
`commit' and put (commit commit) above.
I a comment, I also mentioned the commit was actually a version bump,
which is the reason why there is no revision number.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0sd8r3icaj2gl7f62fyzlwkkb05mc3cwsqgicw0n1x07s5ir3129"))))
> + (build-system emacs-build-system)
> + (native-inputs (list texinfo))
Nitpick: native inputs are usually listed after arguments.
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases
> + %standard-phases
> + (add-after 'install 'makeinfo
> + (lambda* (#:key outputs #:allow-other-keys)
Since you don't use `output' key, (lambda _ ...) is sufficient.
> + (install-file
> + "beframe.info"
> + (string-append #$output "/share/info")))))))
Nitpick: I think a better indentation is:
(install-file "beframe.info"
(string-append #$output "/share/info"))
> + (description
> + "Beframe enables a frame-oriented Emacs workflow where each frame has
> +access to the list of buffers visited therein. In the interest of brevity, we
> +call buffers that belong to frames \"beframed\". Producing multiple
> frames does
In Texinfo, double quotes are ``...'', not "...".
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2023-03-30 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 13:44 [bug#62503] emacs-beframe sourcepluck
2023-03-30 20:50 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6u2klpg.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=62503-done@debbugs.gnu.org \
--cc=sourcepluck@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).