From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iPZ8Jzz2JWSs0AAASxT56A (envelope-from ) for ; Thu, 30 Mar 2023 22:51:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WE5GJzz2JWRcIwAAauVa8A (envelope-from ) for ; Thu, 30 Mar 2023 22:51:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68B5A745C for ; Thu, 30 Mar 2023 22:51:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phzEf-0007D1-9D; Thu, 30 Mar 2023 16:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phzEd-0007CA-3y for guix-patches@gnu.org; Thu, 30 Mar 2023 16:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phzEc-0002v2-KK for guix-patches@gnu.org; Thu, 30 Mar 2023 16:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phzEc-00056s-4k for guix-patches@gnu.org; Thu, 30 Mar 2023 16:51:02 -0400 Subject: bug#62503: emacs-beframe Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 30 Mar 2023 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62503 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: sourcepluck@posteo.net Cc: 62503-done@debbugs.gnu.org Mail-Followup-To: 62503@debbugs.gnu.org, mail@nicolasgoaziou.fr, sourcepluck@posteo.net Received: via spool by 62503-done@debbugs.gnu.org id=D62503.168020945419625 (code D ref 62503); Thu, 30 Mar 2023 20:51:01 +0000 Received: (at 62503-done) by debbugs.gnu.org; 30 Mar 2023 20:50:54 +0000 Received: from localhost ([127.0.0.1]:59555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phzET-00056T-IO for submit@debbugs.gnu.org; Thu, 30 Mar 2023 16:50:53 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:41687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phzER-00056E-DO for 62503-done@debbugs.gnu.org; Thu, 30 Mar 2023 16:50:52 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 8547A240002; Thu, 30 Mar 2023 20:50:44 +0000 (UTC) From: Nicolas Goaziou References: Date: Thu, 30 Mar 2023 22:50:35 +0200 In-Reply-To: (sourcepluck@posteo.net's message of "Tue, 28 Mar 2023 13:44:26 +0000") Message-ID: <87h6u2klpg.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680209468; a=rsa-sha256; cv=none; b=scJQ2e6vI9n1Eqx8pNRM6GmcAWusdh/J4h0+YDE0djtWSHkbxZkY9Le/VL/tlQZHANObTY zUOClPHVSmD+4O0465PZJjELNJC015+bR8jNoeXpuKUe9AJk2MzlI20Zfi3QTFF4kkAyX3 Xsr9UQvL9vrhfuW8TPBkbJAW9kaIsg788sEToRYroLNB4hw8Bj8ZF5nPK/8LyPYbjgnjXT 8ujY59Sd65Xcwl7BY7ZpIpvOtvWtj38uyUa7LWmk+SMRLUrp6s/THXQ/75k+NG6yXLByqJ uUw2aJW6cuuvkRG0ClE/J2eiKtZL+jU6iCpTTuReV0zSTg//rJeDnaGetukOww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680209468; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Ju7wT75U/ZodXFTEZQcxWo7gajwmHI/CLd42qOsrzo0=; b=u41PSFMAXFXUbFSXAZl3KyIVYKXl5hY2huQPOz8VjIosxFtZo7V9chjQOqz+mn2neBez24 f+D32dnY0twOP4uN3Tq12SyEQTh0jNNHyiZAmOhsxbcFyJMfGYe88P3uudlH6/H/ZWkSJP GbMJ/iTfeG2s25qzoNQx/g9RULCQPSpUpIaNZ0xPHTDQ5Sp+AB/hbMAtm2YpOd+QEEZu4s Eg3387vLf4F2l/xFLU7IDUUjGLZZC0W/bpoQh/F0G/HH3UkLSY1CSzFViwsXV/r6f3hhEx elq+vI7+HhI/Pme16YUPTG87+LEw6k3+dNLS/fDM54Df72WClVKrgGj+SK7BKw== X-Migadu-Spam-Score: -3.32 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -3.32 X-Migadu-Queue-Id: 68B5A745C X-TUID: 9xDJIR8l67Z4 Hello, sourcepluck@posteo.net writes: > Jamie Cullen here. This is my first ever patch, first ever commit, > first ever packaged package, first ever time doing anything mildly > useful with Git, etc etc. Excitement is tantamount here. This sure is a good first patch. Since I had only nitpicks to write, I applied it directly. Thank you! > Please don't hesitate to tell me about even the smallest modification > on my side, and any length of an explanation here via mail. I wrote below what small changes I made to your package definition. > +(define-public emacs-beframe > + (package > + (name "emacs-beframe") > + (version "0.2.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.sr.ht/~protesilaos/beframe") > + (commit "edfab6eefe4ac35cd8d1ed87fc7f670496d25e40"))) We don't usually insert commit hashes here, but rather bind hash to `commit' and put (commit commit) above. I a comment, I also mentioned the commit was actually a version bump, which is the reason why there is no revision number. > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0sd8r3icaj2gl7f62fyzlwkkb05mc3cwsqgicw0n1x07s5ir3129")))) > + (build-system emacs-build-system) > + (native-inputs (list texinfo)) Nitpick: native inputs are usually listed after arguments. > + (arguments > + (list > + #:phases > + #~(modify-phases > + %standard-phases > + (add-after 'install 'makeinfo > + (lambda* (#:key outputs #:allow-other-keys) Since you don't use `output' key, (lambda _ ...) is sufficient. > + (install-file > + "beframe.info" > + (string-append #$output "/share/info"))))))) Nitpick: I think a better indentation is: (install-file "beframe.info" (string-append #$output "/share/info")) > + (description > + "Beframe enables a frame-oriented Emacs workflow where each frame has > +access to the list of buffers visited therein. In the interest of brevity, we > +call buffers that belong to frames \"beframed\". Producing multiple > frames does In Texinfo, double quotes are ``...'', not "...". Regards, -- Nicolas Goaziou