bug#26934: [PATCH 1/3] gnu: video: add libzen

[ludo@gnu.org (Ludovic Courtès)]

Hi Ethan,

doubleplusgood23@gmail.com (Ethan R. Jones) skribis:

>>> ---
>>>  gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 42 insertions(+)
>
>>Could you provide ChangeLog-style commit logs?  See ‘git log’ for
>>examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html>.
>
> So I should independently `git add --patch` each addition, then do a multi-line
> `git commit` like so:
>
>     gnu: foo: Update to 1.0.
>     
>     * gnu/packages/foo.scm (foo): Update to 1.0
>     * gnu/packages/foo.scm (libbar): New shared library.

(“New variable”, not “new shared library”, because technically ‘libbar’
is a variable in foo.scm.  :-))  But yes, as noted there, it should
typically be one patch per addition.

>>Could you squeeze that on one or two lines?
>
> Is there a style on when to squeeze and when to not?

There’s no written guideline for that, but you can check what other
files do.  Essentially, if this can fit in two 80-column lines rather
than 5 lines, just choose the former.

>>Please double-check that this is needed.
>
> Yup, all packages lack a proper configure script.

OK, perfect.

>>Could you improve the synopsis and description
>
> Do you have any ideas of what to add? I wasn't sure where to start
> myself

I don’t know those pieces of software, but a good start for the
description is typically their Web page or their ‘README’ file.

Thanks in advance!

Ludo’.