From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBHNm-0003ho-IS
	for guix-patches@gnu.org; Thu, 18 May 2017 05:06:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBHNi-0002Ed-Hm
	for guix-patches@gnu.org; Thu, 18 May 2017 05:06:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49193)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dBHNi-0002EX-Ay
	for guix-patches@gnu.org; Thu, 18 May 2017 05:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBHNi-0001Ji-1P
	for guix-patches@gnu.org; Thu, 18 May 2017 05:06:02 -0400
Subject: bug#26934: [PATCH 1/3] gnu: video: add libzen
Resent-Message-ID: <handler.26934.B26934.14950983154987@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <874lwjt598.fsf@gmail.com>
Date: Thu, 18 May 2017 11:04:59 +0200
In-Reply-To: <874lwjt598.fsf@gmail.com> (Ethan R. Jones's message of "Wed, 17
	May 2017 19:47:47 -0400")
Message-ID: <87fug2a62s.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Ethan R. Jones" <doubleplusgood23@gmail.com>
Cc: 26934@debbugs.gnu.org

Hi Ethan,

doubleplusgood23@gmail.com (Ethan R. Jones) skribis:

>>> ---
>>>  gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 42 insertions(+)
>
>>Could you provide ChangeLog-style commit logs?  See =E2=80=98git log=E2=
=80=99 for
>>examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.=
html>.
>
> So I should independently `git add --patch` each addition, then do a mult=
i-line
> `git commit` like so:
>
>     gnu: foo: Update to 1.0.
>=20=20=20=20=20
>     * gnu/packages/foo.scm (foo): Update to 1.0
>     * gnu/packages/foo.scm (libbar): New shared library.

(=E2=80=9CNew variable=E2=80=9D, not =E2=80=9Cnew shared library=E2=80=9D, =
because technically =E2=80=98libbar=E2=80=99
is a variable in foo.scm.  :-))  But yes, as noted there, it should
typically be one patch per addition.

>>Could you squeeze that on one or two lines?
>
> Is there a style on when to squeeze and when to not?

There=E2=80=99s no written guideline for that, but you can check what other
files do.  Essentially, if this can fit in two 80-column lines rather
than 5 lines, just choose the former.

>>Please double-check that this is needed.
>
> Yup, all packages lack a proper configure script.

OK, perfect.

>>Could you improve the synopsis and description
>
> Do you have any ideas of what to add? I wasn't sure where to start
> myself

I don=E2=80=99t know those pieces of software, but a good start for the
description is typically their Web page or their =E2=80=98README=E2=80=99 f=
ile.

Thanks in advance!

Ludo=E2=80=99.