From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>
Cc: 40128@debbugs.gnu.org
Subject: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sat, 21 Mar 2020 17:38:28 +0100 [thread overview]
Message-ID: <87fte18xyz.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871rpoq4tj.fsf@lafreniere.xyz> (Joseph LaFreniere's message of "Thu, 19 Mar 2020 00:41:44 -0500")
Hello,
"LaFreniere, Joseph" <joseph@lafreniere.xyz> writes:
> Patch file is attached.
Thank you.
> As noted in the description, this package is not intended for use by
> end-users. Is there a convention for communicating that?
I think specifying it in the description is the correct way.
> + (propagated-inputs
> + `(("emacs-hydra" ,emacs-hydra)
> + ("emacs-s" ,emacs-s)
> + ("emacs-dash" ,emacs-dash)))
Could you re-order them alphabetically?
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'add-source-to-load-path 'remove-pretty-hydra
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; major-mode-hydra is packaged separately.
> + (delete-file "major-mode-hydra.el")
> + #t)))))
You can use #:exclude keyword from the Emacs build system instead.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-03-21 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 5:41 [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra LaFreniere, Joseph
2020-03-19 5:46 ` [bug#40128] [PATCH 2/2] gnu: Add emacs-major-mode-hydra LaFreniere, Joseph
2020-03-21 16:41 ` Nicolas Goaziou
2020-03-21 23:13 ` LaFreniere, Joseph
2020-03-21 16:38 ` Nicolas Goaziou [this message]
2020-03-21 23:12 ` [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra LaFreniere, Joseph
2020-04-19 17:57 ` LaFreniere, Joseph
2020-04-19 18:28 ` Nicolas Goaziou
2020-04-19 19:24 ` LaFreniere, Joseph
2020-11-21 9:12 ` bug#40128: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fte18xyz.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40128@debbugs.gnu.org \
--cc=joseph@lafreniere.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).