From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50434)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFh9K-0000SU-TJ
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:39:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFh9J-00087l-VY
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:39:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41912)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFh9J-00087h-SX
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:39:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFh9J-0006rJ-PB
 for guix-patches@gnu.org; Sat, 21 Mar 2020 12:39:01 -0400
Subject: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Resent-Message-ID: <handler.40128.B40128.158480871826322@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <871rpoq4tj.fsf@lafreniere.xyz>
Date: Sat, 21 Mar 2020 17:38:28 +0100
In-Reply-To: <871rpoq4tj.fsf@lafreniere.xyz> (Joseph LaFreniere's message of
 "Thu, 19 Mar 2020 00:41:44 -0500")
Message-ID: <87fte18xyz.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>
Cc: 40128@debbugs.gnu.org

Hello,

"LaFreniere, Joseph" <joseph@lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> As noted in the description, this package is not intended for use by
> end-users.  Is there a convention for communicating that?

I think specifying it in the description is the correct way.

> +    (propagated-inputs
> +     `(("emacs-hydra" ,emacs-hydra)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-dash" ,emacs-dash)))

Could you re-order them alphabetically?

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'add-source-to-load-path 'remove-pretty-hydra
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; major-mode-hydra is packaged separately.
> +             (delete-file "major-mode-hydra.el")
> +             #t)))))

You can use #:exclude keyword from the Emacs build system instead.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou