unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40646@debbugs.gnu.org
Subject: [bug#40646] gnu: Add blueman.
Date: Mon, 20 Apr 2020 00:21:23 +0200	[thread overview]
Message-ID: <87ftcz15i4.fsf@gnu.org> (raw)
In-Reply-To: <d2de2966651eb643a7a2e1ebfeb3f26f@disroot.org> (Raghav Gururajan's message of "Sun, 19 Apr 2020 11:27:31 +0000")

Hi,

"Raghav Gururajan" <raghavgururajan@disroot.org> skribis:

>>> + (substitute* "apps/blueman-adapters.in"
>>> + (("@PYTHON@") (string-append (assoc-ref inputs "python")
>>> + "/bin/python3.7")))
>> 
>> Are you sure this is necessary? If these are scripts, the
>> ‘patch-shebangs’ phase should take care of it. Perhaps it’s enough to
>> add ‘python-wrapper’ as an input (it provides a “python” executable) and
>> then you can remove all this?
>
> It is not necessary. Those scripts were not patched by 'patch-shebangs' phase, and received warnings during build. So corrected them manually. :-)

I think you overlooked the rest of my comment: if you add
‘python-wrapper’ as an input, everything will be fine.

Could you check?

Thanks in advance!

Ludo’.

  reply	other threads:[~2020-04-19 22:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 17:52 [bug#40646] gnu: Add blueman Raghav Gururajan
2020-04-19 11:22 ` Ludovic Courtès
2020-04-19 11:27 ` Raghav Gururajan
2020-04-19 22:21   ` Ludovic Courtès [this message]
2020-04-20  0:25     ` Raghav Gururajan
2020-04-20  6:10       ` [bug#40646] gnu: Add blueman. (v2) Raghav Gururajan
2020-04-22 15:20         ` bug#40646: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftcz15i4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40646@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).