From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35906 helo=eggs1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQIKA-0007Cr-Tr for guix-patches@gnu.org; Sun, 19 Apr 2020 18:22:03 -0400 Received: from Debian-exim by eggs1p.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jQIKA-00020w-JA for guix-patches@gnu.org; Sun, 19 Apr 2020 18:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34597) by eggs1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jQIKA-00020p-6w for guix-patches@gnu.org; Sun, 19 Apr 2020 18:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jQIKA-0002MS-3H for guix-patches@gnu.org; Sun, 19 Apr 2020 18:22:02 -0400 Subject: [bug#40646] gnu: Add blueman. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87mu773ekd.fsf@gnu.org> <20200415135234.3bd638ea.raghavgururajan@disroot.org> Date: Mon, 20 Apr 2020 00:21:23 +0200 In-Reply-To: (Raghav Gururajan's message of "Sun, 19 Apr 2020 11:27:31 +0000") Message-ID: <87ftcz15i4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 40646@debbugs.gnu.org Hi, "Raghav Gururajan" skribis: >>> + (substitute* "apps/blueman-adapters.in" >>> + (("@PYTHON@") (string-append (assoc-ref inputs "python") >>> + "/bin/python3.7"))) >>=20 >> Are you sure this is necessary? If these are scripts, the >> =E2=80=98patch-shebangs=E2=80=99 phase should take care of it. Perhaps i= t=E2=80=99s enough to >> add =E2=80=98python-wrapper=E2=80=99 as an input (it provides a =E2=80= =9Cpython=E2=80=9D executable) and >> then you can remove all this? > > It is not necessary. Those scripts were not patched by 'patch-shebangs' p= hase, and received warnings during build. So corrected them manually. :-) I think you overlooked the rest of my comment: if you add =E2=80=98python-wrapper=E2=80=99 as an input, everything will be fine. Could you check? Thanks in advance! Ludo=E2=80=99.