unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: 40617@debbugs.gnu.org
Subject: [bug#40617] sysbench (New package)
Date: Tue, 28 Apr 2020 10:28:21 +0200	[thread overview]
Message-ID: <87ftcot3oa.fsf@gmail.com> (raw)
In-Reply-To: <87ftcouiws.fsf@gmail.com> (Mathieu Othacehe's message of "Tue, 28 Apr 2020 10:13:55 +0200")


Hello Eric,

Thanks for the patch.

> +    (version "1.0.19")

Looks like 1.0.20 is out there.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/akopytov/sysbench")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1zgqb9cr7ld3vw4a3jhq1mlszhcyjlpr0c8q1jcp1d27l9dcvd1w"))
> +       (modules '((guix build utils)))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; until shebangs fixed

Tests can run but you actually need to modify run_tests.sh so that it's
able to locate the python interpreter.

> +       (modify-phases %standard-phases
> +         (delete 'bootstrap)
> +         (add-after 'patch-source-shebangs 'libtoolize
> +           (lambda _ (invoke "libtoolize" "--copy" "--force")))
> +         (add-after 'libtoolize 'aclocal
> +           (lambda _ (invoke "aclocal" "-I" "m4")))
> +         (add-after 'aclocal 'autoreconf
> +           (lambda _ (invoke "autoreconf" "--install")))
> +         (add-after 'autoreconf 'automake
> +           (lambda _ (invoke "automake"
> +                             "-c" "--foreign" "--add-missing")))
> +         (add-after 'automake 'autoconf
> +           (lambda _ (invoke "autoconf"))))))

You can remove all this block by just adding "which" to the
native-inputs list :)

> +    (synopsis "Scriptable multi-threaded benchmark tool ")

Trailing space at the end of the sentence.

> +    (description "sysbench is a scriptable multi-threaded benchmark tool based
> +on LuaJIT. It is most frequently used for database benchmarks, but can also be
> +used to create arbitrarily complex workloads that do not involve a database
> +server.")

Please remember to run `guix lint' before submitting.

Thanks,

Mathieu

  parent reply	other threads:[~2020-04-28  8:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  1:55 [bug#40617] sysbench (New package) Eric Brown
     [not found] ` <87ftcouiws.fsf@gmail.com>
2020-04-28  8:28   ` Mathieu Othacehe [this message]
2020-11-21 10:27     ` Christopher Baines
2021-05-26 22:28       ` Eric Brown
2022-03-21 17:37         ` bug#40617: " Maxim Cournoyer
2020-07-25  2:15   ` [bug#40617] " Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftcot3oa.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=40617@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).