From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50836)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTLtV-0003ad-4f
 for guix-patches@gnu.org; Tue, 28 Apr 2020 04:48:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTLby-0002oI-Dp
 for guix-patches@gnu.org; Tue, 28 Apr 2020 04:32:49 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55494)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jTLby-0002mo-2a
 for guix-patches@gnu.org; Tue, 28 Apr 2020 04:29:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTLbx-0007rj-WD
 for guix-patches@gnu.org; Tue, 28 Apr 2020 04:29:02 -0400
Subject: [bug#40617] sysbench (New package)
Resent-Message-ID: <handler.40617.B40617.158806251030197@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <874ktm7rw2.fsf@ericcbrown.com> <87ftcouiws.fsf@gmail.com>
Date: Tue, 28 Apr 2020 10:28:21 +0200
In-Reply-To: <87ftcouiws.fsf@gmail.com> (Mathieu Othacehe's message of "Tue,
 28 Apr 2020 10:13:55 +0200")
Message-ID: <87ftcot3oa.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 40617@debbugs.gnu.org


Hello Eric,

Thanks for the patch.

> +    (version "1.0.19")

Looks like 1.0.20 is out there.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/akopytov/sysbench")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1zgqb9cr7ld3vw4a3jhq1mlszhcyjlpr0c8q1jcp1d27l9dcvd1w"))
> +       (modules '((guix build utils)))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; until shebangs fixed

Tests can run but you actually need to modify run_tests.sh so that it's
able to locate the python interpreter.

> +       (modify-phases %standard-phases
> +         (delete 'bootstrap)
> +         (add-after 'patch-source-shebangs 'libtoolize
> +           (lambda _ (invoke "libtoolize" "--copy" "--force")))
> +         (add-after 'libtoolize 'aclocal
> +           (lambda _ (invoke "aclocal" "-I" "m4")))
> +         (add-after 'aclocal 'autoreconf
> +           (lambda _ (invoke "autoreconf" "--install")))
> +         (add-after 'autoreconf 'automake
> +           (lambda _ (invoke "automake"
> +                             "-c" "--foreign" "--add-missing")))
> +         (add-after 'automake 'autoconf
> +           (lambda _ (invoke "autoconf"))))))

You can remove all this block by just adding "which" to the
native-inputs list :)

> +    (synopsis "Scriptable multi-threaded benchmark tool ")

Trailing space at the end of the sentence.

> +    (description "sysbench is a scriptable multi-threaded benchmark tool based
> +on LuaJIT. It is most frequently used for database benchmarks, but can also be
> +used to create arbitrarily complex workloads that do not involve a database
> +server.")

Please remember to run `guix lint' before submitting.

Thanks,

Mathieu