From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 41778-done@debbugs.gnu.org
Subject: bug#41778: [PATCH 0/3] Add ppsspp
Date: Tue, 30 Jun 2020 17:08:31 +0200 [thread overview]
Message-ID: <87ftaciob4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <2aaef91e896f56a9f06a696a8c4e75c8b4cc65bf.camel@student.tugraz.at> (Leo Prikler's message of "Tue, 30 Jun 2020 01:33:52 +0200")
Hello,
Leo Prikler <leo.prikler@student.tugraz.at> writes:
> No, but I'd imagine it would not work out great, because the source is
> a git checkout in /gnu/store, which is read-only and it is compiled in-
> place.
Oh ok. I didn't get it was compiled in-place.
> I'm looking mostly at the contents of ext/ here, which has stuff we
> already package, like cityhash among others. A bit of context is given
> in the unbundling snippet I use for glslang and spirv-cross, which I've
> managed to unbundle, but the rest are not pulled in as submodules, so
> it would require a `guix build --source` and manual analysis to sift
> through all that.
> I don't think a less vague comment could improve this understanding
> without risking to be invalidated at some point in the future. Perhaps
> I could clarify, that it's "mostly ext/", but even that is not
> completely true, since upstream also has ffmpeg as a toplevel submodule
> (which I don't pull in, instead using the flags they already provide
> for using system ffmpeg).
Fair enough.
>> Otherwise, LGTM, barring the description of spirv-cross, where I
>> suggest
>> to drop the "NOTE:" part. It reminds me taisei package felt through
>> the
>> cracks. I'll apply it once spirv-cross is pushed.
> To be fair, that's where I copied it from – I think I already mentioned
> that.
I know. And this is what reminded about taisei.
> I just updated the version and added some details in the comment
> regarding failing tests and hence added my updated patch. I also think
> this description to be quite weird, but at the same time am unsure on
> how to better rephrase it. I will send an updated version of it once I
> do come up with something better than just dropping the "NOTE:" part.
Well, I still think dropping the note is appropriate, but I won't fight
over it. Let me know if you find something that suits you better.
I applied your patches. I tweaked comments. In particular comments
starting with two semicolons are full sentences and are supposed to
start with a capital and end with a full stop.
Thank you!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-06-30 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 21:40 [bug#41778] [PATCH WIP 0/2] Add ppsspp Leo Prikler
2020-06-09 21:47 ` [bug#41778] [PATCH 1/2] gnu: Add armips Leo Prikler
2020-06-09 21:47 ` [bug#41778] [PATCH 2/2] gnu: Add ppsspp Leo Prikler
2020-06-29 10:02 ` [bug#41778] [PATCH 0/3] " Leo Prikler
2020-06-29 10:06 ` [bug#41778] [PATCH 1/3] gnu: Add armips Leo Prikler
2020-06-29 10:06 ` [bug#41778] [PATCH 2/3] gnu: add spirv-cross Leo Prikler
2020-06-29 10:06 ` [bug#41778] [PATCH 3/3] gnu: Add ppsspp Leo Prikler
2020-06-29 22:02 ` [bug#41778] [PATCH 0/3] " Nicolas Goaziou
2020-06-29 23:33 ` Leo Prikler
2020-06-30 15:08 ` Nicolas Goaziou [this message]
2020-06-30 21:31 ` Leo Prikler
2020-07-01 10:15 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftaciob4.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41778-done@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).