From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yKA7AZVV+142KwAA0tVLHw (envelope-from ) for ; Tue, 30 Jun 2020 15:09:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YBWJOJRV+17ZTQAAB5/wlQ (envelope-from ) for ; Tue, 30 Jun 2020 15:09:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 710A5940656 for ; Tue, 30 Jun 2020 15:09:08 +0000 (UTC) Received: from localhost ([::1]:45148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqHsg-0004Jq-G3 for larch@yhetil.org; Tue, 30 Jun 2020 11:09:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqHsc-0004JL-Nk for guix-patches@gnu.org; Tue, 30 Jun 2020 11:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqHsc-0005zI-Eo for guix-patches@gnu.org; Tue, 30 Jun 2020 11:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jqHsc-00069H-AO for guix-patches@gnu.org; Tue, 30 Jun 2020 11:09:02 -0400 Subject: bug#41778: [PATCH 0/3] Add ppsspp Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 30 Jun 2020 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41778 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 41778-done@debbugs.gnu.org Mail-Followup-To: 41778@debbugs.gnu.org, mail@nicolasgoaziou.fr, leo.prikler@student.tugraz.at Received: via spool by 41778-done@debbugs.gnu.org id=D41778.159352972523606 (code D ref 41778); Tue, 30 Jun 2020 15:09:02 +0000 Received: (at 41778-done) by debbugs.gnu.org; 30 Jun 2020 15:08:45 +0000 Received: from localhost ([127.0.0.1]:51442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqHsL-00068f-BW for submit@debbugs.gnu.org; Tue, 30 Jun 2020 11:08:45 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:52355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqHsI-00068Q-NI for 41778-done@debbugs.gnu.org; Tue, 30 Jun 2020 11:08:43 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 23BCC10000F; Tue, 30 Jun 2020 15:08:34 +0000 (UTC) From: Nicolas Goaziou References: <785a75894730f36908da7c0775f85058eb32787e.camel@student.tugraz.at> <0e2c18a84e232f73a72d755a692feaece0118396.camel@student.tugraz.at> <87wo3pil8j.fsf@nicolasgoaziou.fr> <2aaef91e896f56a9f06a696a8c4e75c8b4cc65bf.camel@student.tugraz.at> Date: Tue, 30 Jun 2020 17:08:31 +0200 In-Reply-To: <2aaef91e896f56a9f06a696a8c4e75c8b4cc65bf.camel@student.tugraz.at> (Leo Prikler's message of "Tue, 30 Jun 2020 01:33:52 +0200") Message-ID: <87ftaciob4.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: vBQEveaZrsk9 Hello, Leo Prikler writes: > No, but I'd imagine it would not work out great, because the source is > a git checkout in /gnu/store, which is read-only and it is compiled in- > place. Oh ok. I didn't get it was compiled in-place. > I'm looking mostly at the contents of ext/ here, which has stuff we > already package, like cityhash among others. A bit of context is given > in the unbundling snippet I use for glslang and spirv-cross, which I've > managed to unbundle, but the rest are not pulled in as submodules, so > it would require a `guix build --source` and manual analysis to sift > through all that.=20=20 > I don't think a less vague comment could improve this understanding > without risking to be invalidated at some point in the future. Perhaps > I could clarify, that it's "mostly ext/", but even that is not > completely true, since upstream also has ffmpeg as a toplevel submodule > (which I don't pull in, instead using the flags they already provide > for using system ffmpeg). Fair enough. >> Otherwise, LGTM, barring the description of spirv-cross, where I >> suggest >> to drop the "NOTE:" part. It reminds me taisei package felt through >> the >> cracks. I'll apply it once spirv-cross is pushed. > To be fair, that's where I copied it from =E2=80=93 I think I already men= tioned > that. I know. And this is what reminded about taisei. > I just updated the version and added some details in the comment > regarding failing tests and hence added my updated patch. I also think > this description to be quite weird, but at the same time am unsure on > how to better rephrase it. I will send an updated version of it once I > do come up with something better than just dropping the "NOTE:" part. Well, I still think dropping the note is appropriate, but I won't fight over it. Let me know if you find something that suits you better. I applied your patches. I tweaked comments. In particular comments starting with two semicolons are full sentences and are supposed to start with a capital and end with a full stop. Thank you! Regards, --=20 Nicolas Goaziou