From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 42123@debbugs.gnu.org
Subject: [bug#42123] [PATCH] linux-libre: Enable module compression.
Date: Sun, 23 Aug 2020 18:27:45 +0200 [thread overview]
Message-ID: <87ft8dba4e.fsf@gnu.org> (raw)
In-Reply-To: <871rkjvqgf.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 06 Aug 2020 15:44:48 +0200")
Hello!
Apologies for the holiday-induced delay!
Mathieu Othacehe <othacehe@gnu.org> skribis:
>> This can be decomposed in several steps:
>>
>> 1. We can start using ‘guile-zlib’ as extensions for gexps: in (guix
>> scripts pack), (guix download), etc. Easy, no risk.
>
> There's an attached patch that should cover this first step. An issue
> here is that (guix build download-nar) is built in both "make" and "guix
> pull" commands, so I cannot use a bare:
>
> #:use-module (zlib)
>
>
> so, I used:
>
> #:autoload (zlib) (call-with-gzip-input-port)
>
> that seems to work but produces a lot of warnings when running
> "make". Would it be acceptable as a first step?
Yeah, sounds good to me.
>> 2. Use guile-zlib & co. in Guix itself: (guix scripts substitute),
>> (guix scripts publish), etc. Keep (guix zlib) and (guix lzlib) in
>> parallel.
>
> I'm not sure how it can work without step 4. For me, including (zlib) in
> Guix itself requires that build machinery and (guix self) are updated,
> but maybe I'm missing something.
Hmm you must be right. Well in that case you can do these in lockstep.
Sorry for the confusion!
> From 680e19137d22204f34b00336a3cb98a02397b0f9 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <othacehe@gnu.org>
> Date: Thu, 6 Aug 2020 15:00:01 +0200
> Subject: [PATCH] Use guile-zlib extension in build-side code.
>
> * Makefile.am (MODULES): Move guix/build/download-nar.scm to ...
> (MODULES_NOT_COMPILED): ... here.
> * guix/build/download-nar.scm: Use (zlib) instead of (guix zlib).
> * guix/cvs-download.scm (cvs-fetch): Do not stub (guix config) in imported
> modules list, instead add "guile-zlib" to the extension list.
> * guix/git-download.scm (git-fetch): Ditto.
> * guix/hg-download.scm (hg-fetch): Do not stub (guix config) in imported
> modules list, instead add "guile-zlib" to the extension list.
LGTM! Glad we’re making progress on this front, thanks a lot!
Ludo’.
next prev parent reply other threads:[~2020-08-23 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 14:24 [bug#42123] [PATCH] linux-libre: Enable module compression Mathieu Othacehe
2020-06-30 7:31 ` Mathieu Othacehe
2020-07-02 10:23 ` Ludovic Courtès
2020-07-06 8:48 ` Mathieu Othacehe
2020-07-06 12:20 ` Ludovic Courtès
2020-07-06 14:23 ` Mathieu Othacehe
2020-07-06 20:13 ` Ludovic Courtès
2020-07-07 7:32 ` Mathieu Othacehe
2020-07-09 7:56 ` Ludovic Courtès
2020-07-27 16:24 ` Mathieu Othacehe
2020-07-28 22:16 ` Ludovic Courtès
2020-08-06 13:44 ` Mathieu Othacehe
2020-08-23 16:27 ` Ludovic Courtès [this message]
2020-08-24 11:38 ` Mathieu Othacehe
2020-08-24 14:03 ` Ludovic Courtès
2020-08-25 10:30 ` bug#42123: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft8dba4e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42123@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).