From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qHCUGxeZQl+PDQAA0tVLHw (envelope-from ) for ; Sun, 23 Aug 2020 16:28:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CO1rFxeZQl/UKgAAbx9fmQ (envelope-from ) for ; Sun, 23 Aug 2020 16:28:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB11C9404C5 for ; Sun, 23 Aug 2020 16:28:06 +0000 (UTC) Received: from localhost ([::1]:55722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9sqj-0007lg-Jx for larch@yhetil.org; Sun, 23 Aug 2020 12:28:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9sqg-0007lL-IV for guix-patches@gnu.org; Sun, 23 Aug 2020 12:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9sqg-0002Z4-9d for guix-patches@gnu.org; Sun, 23 Aug 2020 12:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9sqg-0006vG-7H for guix-patches@gnu.org; Sun, 23 Aug 2020 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42123] [PATCH] linux-libre: Enable module compression. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Aug 2020 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42123 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42123@debbugs.gnu.org Received: via spool by 42123-submit@debbugs.gnu.org id=B42123.159820007626598 (code B ref 42123); Sun, 23 Aug 2020 16:28:02 +0000 Received: (at 42123) by debbugs.gnu.org; 23 Aug 2020 16:27:56 +0000 Received: from localhost ([127.0.0.1]:54991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9sqa-0006uw-0L for submit@debbugs.gnu.org; Sun, 23 Aug 2020 12:27:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9sqX-0006uk-U3 for 42123@debbugs.gnu.org; Sun, 23 Aug 2020 12:27:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55455) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9sqS-0002WX-Mk for 42123@debbugs.gnu.org; Sun, 23 Aug 2020 12:27:48 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38330 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k9sqQ-0003b0-St; Sun, 23 Aug 2020 12:27:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200629142434.21308-1-othacehe@gnu.org> <87366atdve.fsf@gnu.org> <87lfjx6nb9.fsf@gnu.org> <873664ltqt.fsf@gnu.org> <878sfw7mec.fsf@gnu.org> <871rloiept.fsf@gnu.org> <874kqjn5k4.fsf@gnu.org> <874kqhcea1.fsf@gnu.org> <87v9i9exjq.fsf@gnu.org> <87tuxrqo9k.fsf@gnu.org> <871rkjvqgf.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 23 Aug 2020 18:27:45 +0200 In-Reply-To: <871rkjvqgf.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 06 Aug 2020 15:44:48 +0200") Message-ID: <87ft8dba4e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: pd9bLseDAArd Hello! Apologies for the holiday-induced delay! Mathieu Othacehe skribis: >> This can be decomposed in several steps: >> >> 1. We can start using =E2=80=98guile-zlib=E2=80=99 as extensions for g= exps: in (guix >> scripts pack), (guix download), etc. Easy, no risk. > > There's an attached patch that should cover this first step. An issue > here is that (guix build download-nar) is built in both "make" and "guix > pull" commands, so I cannot use a bare: > > #:use-module (zlib) > > > so, I used: > > #:autoload (zlib) (call-with-gzip-input-port) > > that seems to work but produces a lot of warnings when running > "make". Would it be acceptable as a first step? Yeah, sounds good to me. >> 2. Use guile-zlib & co. in Guix itself: (guix scripts substitute), >> (guix scripts publish), etc. Keep (guix zlib) and (guix lzlib) in >> parallel. > > I'm not sure how it can work without step 4. For me, including (zlib) in > Guix itself requires that build machinery and (guix self) are updated, > but maybe I'm missing something. Hmm you must be right. Well in that case you can do these in lockstep. Sorry for the confusion! > From 680e19137d22204f34b00336a3cb98a02397b0f9 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Thu, 6 Aug 2020 15:00:01 +0200 > Subject: [PATCH] Use guile-zlib extension in build-side code. > > * Makefile.am (MODULES): Move guix/build/download-nar.scm to ... > (MODULES_NOT_COMPILED): ... here. > * guix/build/download-nar.scm: Use (zlib) instead of (guix zlib). > * guix/cvs-download.scm (cvs-fetch): Do not stub (guix config) in imported > modules list, instead add "guile-zlib" to the extension list. > * guix/git-download.scm (git-fetch): Ditto. > * guix/hg-download.scm (hg-fetch): Do not stub (guix config) in imported > modules list, instead add "guile-zlib" to the extension list. LGTM! Glad we=E2=80=99re making progress on this front, thanks a lot! Ludo=E2=80=99.