unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#51973] [PATCH] gnu: mycli: Update to 1.24.1.
@ 2021-11-19 11:19 jgart via Guix-patches via
  2021-11-19 16:08 ` bug#51973: " Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2021-11-19 11:19 UTC (permalink / raw)
  To: 51973; +Cc: jgart

* gnu/packages/databases.scm (mycli): Update to 1.24.1.
[propagated-inputs]: Add missing dependencies.
---
 gnu/packages/databases.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index de161e1864..c1582c709a 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -145,6 +145,7 @@ (define-module (gnu packages databases)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages valgrind)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -618,13 +619,13 @@ (define-public python2-pylibmc
 (define-public mycli
   (package
     (name "mycli")
-    (version "1.22.2")
+    (version "1.24.1")
     (source
       (origin
         (method url-fetch)
         (uri (pypi-uri "mycli" version))
         (sha256
-          (base32 "1lq2x95553vdmhw13cxcgsd2g2i32izhsb7hxd4m1iwf9b3msbpv"))))
+          (base32 "0rij9nw20zhqr7cqnkm8daw8b1wdc9zb6ny1ji9qz5557nz9i3bl"))))
     (build-system python-build-system)
     (arguments
      `(#:tests? #f))                    ; tests expect a running MySQL
@@ -634,8 +635,10 @@ (define-public mycli
         ("python-configobj" ,python-configobj)
         ("python-cryptography" ,python-cryptography)
         ("python-prompt-toolkit" ,python-prompt-toolkit)
+        ("python-pyaes" ,python-pyaes)
         ("python-pygments" ,python-pygments)
         ("python-pymysql" ,python-pymysql)
+        ("python-pyperclip" ,python-pyperclip)
         ("python-sqlparse" ,python-sqlparse)))
     (home-page "http://mycli.net")
     (synopsis
-- 
2.34.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#51973: [PATCH] gnu: mycli: Update to 1.24.1.
  2021-11-19 11:19 [bug#51973] [PATCH] gnu: mycli: Update to 1.24.1 jgart via Guix-patches via
@ 2021-11-19 16:08 ` Arun Isaac
  2021-11-19 17:44   ` [bug#51973] " jgart via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2021-11-19 16:08 UTC (permalink / raw)
  To: jgart; +Cc: 51973-done

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]


Hi jgart,

Thanks for the patch! I pushed it to master after adding a copyright
header and fixing your commit message as follows.

> [propagated-inputs]: Add missing dependencies.

^ In this line, I explicitly listed the new dependencies.

Regards,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#51973] [PATCH] gnu: mycli: Update to 1.24.1.
  2021-11-19 16:08 ` bug#51973: " Arun Isaac
@ 2021-11-19 17:44   ` jgart via Guix-patches via
  2021-11-22  9:48     ` Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2021-11-19 17:44 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 51973-done

On Fri, 19 Nov 2021 21:38:33 +0530 Arun Isaac <arunisaac@systemreboot.net> wrote:
> 
> Hi jgart,
> 
> Thanks for the patch! I pushed it to master after adding a copyright
> header and fixing your commit message as follows.
> 
> > [propagated-inputs]: Add missing dependencies.
> 
> ^ In this line, I explicitly listed the new dependencies.

Hi Arun,

I'll make sure to list all inputs changed going forward and adding the copyright statement.

Do you happen to know when it is not required to add a copyright statement?

I think for under ~5-8 lines of code it is not required but I might be wrong on that.

Thank you for reviewing and merging the patch! Much appreciated.

all best,

jgart





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#51973] [PATCH] gnu: mycli: Update to 1.24.1.
  2021-11-19 17:44   ` [bug#51973] " jgart via Guix-patches via
@ 2021-11-22  9:48     ` Arun Isaac
  0 siblings, 0 replies; 4+ messages in thread
From: Arun Isaac @ 2021-11-22  9:48 UTC (permalink / raw)
  To: jgart; +Cc: 51973-done

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]


Hi jgart,

> Do you happen to know when it is not required to add a copyright
> statement?

I add a copyright header all the time, even if only a single character
has been changed! It just seemed like the safest thing to do. I don't
know what the legal requirements are.

> I think for under ~5-8 lines of code it is not required but I might be
> wrong on that.

You can fit a lot into 5-8 lines of code. So, perhaps that is too high
for a minimum limit.

Regards,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-22  9:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19 11:19 [bug#51973] [PATCH] gnu: mycli: Update to 1.24.1 jgart via Guix-patches via
2021-11-19 16:08 ` bug#51973: " Arun Isaac
2021-11-19 17:44   ` [bug#51973] " jgart via Guix-patches via
2021-11-22  9:48     ` Arun Isaac

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).