From: "Ludovic Courtès" <ludo@gnu.org>
To: r0man <roman@burningswell.com>
Cc: 56604-done@debbugs.gnu.org
Subject: bug#56604: [PATCH 0/8] Update Clojure to 1.11.1.
Date: Sat, 23 Jul 2022 00:11:05 +0200 [thread overview]
Message-ID: <87fsisg5mu.fsf@gnu.org> (raw)
In-Reply-To: <cover.1657994905.git.roman@burningswell.com> (r0man's message of "Sat, 16 Jul 2022 20:17:34 +0200")
Hi,
r0man <roman@burningswell.com> skribis:
> This phase makes sure the timestamp of compiled class files is set to a later
> point in time than the timestamp of the corresponding Clojure source files. If
> the timestamps of the class and source files are the same, the Clojure
> compiler will compile the sources again which can lead to issues. This problem
> has been discussed here [1]. The suggested solution was to keep/adjust the
> timestamps of the class files.
Sounds reasonable. It’s a bummer though that the whole phase is pasted
from ant-build-system.scm, the only difference being the timestamps
(1980 instead of 1970).
I added a TODO comment in clojure-build-system.scm when applying the
patch. Could you follow up with a patch to factorize that?
> Btw, I was a bit surprised that in Guix Clojure packages are AOT compiled. The
> general wisdom in the Clojure community seems to be to avoid AOT compilation
> when distributing libraries, and only AOT compiling Uberjars for final
> deployment. Due to issues like I mentioned in clojure-instaparse.
>
> Are we sure that AOT compiling all Clojure source files by default is a good
> idea, instead of just compiling user declared namespaces which Leiningen and
> friends are doing? WDYT?
Not much, but as you might have seen in ./etc/teams.scm, the project is
finally being structured as teams. There’s an opportunity for you to
start a Clojure team and to take the lead! :-)
As a first step, I’d recommend getting in touch with people who have
worked on ‘clojure-build-system’ and packaged things in the past.
> gnu: clojure-tools-cli: Update to 1.0.206.
> gnu: clojure-tools-gitlibs: Update to 2.4.181.
> gnu: clojure-tools-deps-alpha: Update to 0.14.1212.
> gnu: clojure-tools: Update to 1.11.1.1149.
> gnu: clojure: Update to 1.11.1.
> gnu: clojure-algo-generic: Fix test failing under AOT in Clojure 1.11.1.
> gnu: clojure-core-match: Update to 1.0.0.
> gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT).
I adjusted all the commit logs to follow our conventions; please
consider doing this next time:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
The instaparse patch missed the hash update so I did that too.
Thanks!
Ludo’.
next prev parent reply other threads:[~2022-07-22 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 18:17 [bug#56604] [PATCH 0/8] Update Clojure to 1.11.1 r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 1/8] gnu: clojure-tools-cli: Update to 1.0.206.--- r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 2/8] gnu: clojure-tools-gitlibs: Update to 2.4.181.--- r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 3/8] gnu: clojure-tools-deps-alpha: Update to 0.14.1212.--- r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 4/8] gnu: clojure-tools: Update to 1.11.1.1149.--- r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 5/8] gnu: clojure: Update to 1.11.1.This patch updates Clojure to 1.11.1. It also adds the 'reset-class-timestamps r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 6/8] gnu: clojure-algo-generic: Fix test failing under AOT in Clojure 1.11.1 r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 7/8] gnu: clojure-core-match: Update to 1.0.0.--- r0man
2022-07-16 18:24 ` [bug#56604] [PATCH 8/8] gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT).This patch updates clojure-instaparse to 1.4.12. Due to the following AOT r0man
[not found] ` <handler.56604.B.165799563211388.ack@debbugs.gnu.org>
2022-07-17 18:14 ` [bug#56604] Acknowledgement ([PATCH 0/8] Update Clojure to 1.11.1.) Roman Scherer
2022-07-19 15:11 ` [bug#56604] [PATCH 0/8] Update Clojure to 1.11.1 Maxime Devos
2022-07-22 22:11 ` Ludovic Courtès [this message]
2022-08-15 15:36 ` Roman Scherer
2022-09-01 9:09 ` Ludovic Courtès
2022-09-01 10:03 ` Maxime Devos
2022-09-02 10:12 ` Roman Scherer
2022-09-02 9:52 ` Roman Scherer
[not found] ` <handler.56604.D56604.16585278756386.notifdone@debbugs.gnu.org>
2022-07-25 18:06 ` [bug#56604] closed (Re: bug#56604: [PATCH 0/8] Update Clojure to 1.11.1.) Roman Scherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsisg5mu.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=56604-done@debbugs.gnu.org \
--cc=roman@burningswell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).