From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4ELkEbog22KrSwEAbAwnHQ (envelope-from ) for ; Sat, 23 Jul 2022 00:12:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sATGEbog22KcCwAA9RJhRA (envelope-from ) for ; Sat, 23 Jul 2022 00:12:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F07D8E837 for ; Sat, 23 Jul 2022 00:12:09 +0200 (CEST) Received: from localhost ([::1]:48058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oF0sT-00022l-4x for larch@yhetil.org; Fri, 22 Jul 2022 18:12:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF0sM-00022B-KG for guix-patches@gnu.org; Fri, 22 Jul 2022 18:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oF0sM-0003wK-90 for guix-patches@gnu.org; Fri, 22 Jul 2022 18:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oF0sM-0001gF-1X for guix-patches@gnu.org; Fri, 22 Jul 2022 18:12:02 -0400 Subject: bug#56604: [PATCH 0/8] Update Clojure to 1.11.1. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 22 Jul 2022 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: r0man Cc: 56604-done@debbugs.gnu.org Mail-Followup-To: 56604@debbugs.gnu.org, ludo@gnu.org, roman@burningswell.com Received: via spool by 56604-done@debbugs.gnu.org id=D56604.16585278756386 (code D ref 56604); Fri, 22 Jul 2022 22:12:01 +0000 Received: (at 56604-done) by debbugs.gnu.org; 22 Jul 2022 22:11:15 +0000 Received: from localhost ([127.0.0.1]:42658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF0rb-0001ev-0F for submit@debbugs.gnu.org; Fri, 22 Jul 2022 18:11:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF0rZ-0001eg-TD for 56604-done@debbugs.gnu.org; Fri, 22 Jul 2022 18:11:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF0rU-0003sL-FD; Fri, 22 Jul 2022 18:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tNWs8Zn31rSGVwhABg88iEJrF3DcKnj/MvWFffGSUSo=; b=nY4aKZeKUvIu7eM1sFEQ OfZjFur5Da0CHSatkQyCd2jttMM6sYS8/5YC/abY0Xs6/MKGORso3/hV2/wfwt1msbg5g5mMseWex doidElPyxMwv5R4qWaKEEOa0kClvpnQWfDiAjkgHSFZeo1F2Upr/PL26/C5kKxAT5WbAimvxSKhGu qXQhB2UiTuUMOUSforwAUxO4JGJhgEloThfDr7vra/WCU8Fu/5Is0vmSTCEFWAskVf/xXLmof0sIJ q4m36VPr1Izp3VPuXCDkEEN6qGuRXDI+63GOR0hp5/q3xzScemGPwOGnzElMHHAeFJxukxOiiL39N dYdJ+05r64qceQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59843 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF0rU-000165-2Y; Fri, 22 Jul 2022 18:11:08 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 23 Jul 2022 00:11:05 +0200 In-Reply-To: (r0man's message of "Sat, 16 Jul 2022 20:17:34 +0200") Message-ID: <87fsisg5mu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658527930; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tNWs8Zn31rSGVwhABg88iEJrF3DcKnj/MvWFffGSUSo=; b=JGa8E8gKKoQWk2385Xu5oIE00E0tm4w/tQmWQvrP7DNrvdYstyxRI1XDUxYYbq/deZsrem AoKlUzC6OKyPa5WFWh4hVYt4MkWncm/wvPD/iHV3F6GHD6xPkPcgVKFN7ETpMLJxh1Lgbq x0eZ7XbVyZCbjx1+nlMMeG2JrvzqTEySm9WqmFtfQmja6wnPpOx9lyYVlLppsSrRZobwnM E4xjOzskS0orQX/lsX3WbCxaF4CtoGmyr4W/2jgGM58oCPJbYqBsh8XjikHAFifiFEbNDY NjWXZGcfrIFvO3SpMYCdzvME1x6QyL6eMRhYvO81UgqOak912fg2R0fBYK+5zQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658527930; a=rsa-sha256; cv=none; b=aDJAmFcp77wASWijifiDpAMzTnMURHb0kEexRvOBP4hLiaUDK1yE/yqg1CEzXA/N7mgwXv 8FFPA1nxELpXpoq5g4na1pQ+Uer4McuthiRz47thOQZPd1ShPIufnirYk+21FuxsvQX499 BqVQG13CUXYH5THfTtzyDIXOZcwqg274pJqwIMAdSL9y4t8sgCsZrlE77/A2acuGoqqrCd KFlPM8BAg7CLdNcPZ6SgcUmFjCp8KvGc4wHfIEMrIl1DCpiGXYPqCDF+Vk0y/XonHceAU3 c9YxCIhP5SNV/Gb+qqF0Ci7P86nnvviWYXxwa//d7FpSlQT9a9YXWvV0uJoCbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nY4aKZeK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nY4aKZeK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F07D8E837 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: eOoxxFswP9Yb Hi, r0man skribis: > This phase makes sure the timestamp of compiled class files is set to a l= ater > point in time than the timestamp of the corresponding Clojure source file= s. If > the timestamps of the class and source files are the same, the Clojure > compiler will compile the sources again which can lead to issues. This pr= oblem > has been discussed here [1]. The suggested solution was to keep/adjust the > timestamps of the class files. Sounds reasonable. It=E2=80=99s a bummer though that the whole phase is pa= sted from ant-build-system.scm, the only difference being the timestamps (1980 instead of 1970). I added a TODO comment in clojure-build-system.scm when applying the patch. Could you follow up with a patch to factorize that? > Btw, I was a bit surprised that in Guix Clojure packages are AOT compiled= . The > general wisdom in the Clojure community seems to be to avoid AOT compilat= ion > when distributing libraries, and only AOT compiling Uberjars for final > deployment. Due to issues like I mentioned in clojure-instaparse. > > Are we sure that AOT compiling all Clojure source files by default is a g= ood > idea, instead of just compiling user declared namespaces which Leiningen = and > friends are doing? WDYT? Not much, but as you might have seen in ./etc/teams.scm, the project is finally being structured as teams. There=E2=80=99s an opportunity for you = to start a Clojure team and to take the lead! :-) As a first step, I=E2=80=99d recommend getting in touch with people who have worked on =E2=80=98clojure-build-system=E2=80=99 and packaged things in the= past. > gnu: clojure-tools-cli: Update to 1.0.206. > gnu: clojure-tools-gitlibs: Update to 2.4.181. > gnu: clojure-tools-deps-alpha: Update to 0.14.1212. > gnu: clojure-tools: Update to 1.11.1.1149. > gnu: clojure: Update to 1.11.1. > gnu: clojure-algo-generic: Fix test failing under AOT in Clojure 1.11.1. > gnu: clojure-core-match: Update to 1.0.0. > gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT). I adjusted all the commit logs to follow our conventions; please consider doing this next time: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html The instaparse patch missed the hash update so I did that too. Thanks! Ludo=E2=80=99.